This revision was automatically updated to reflect the committed changes.
Closed by commit R124:0aa7fd015b0c: Fix sidebar view regression of not
prompting about unsaved changes (authored by davidedmundson).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
davidedmundson updated this revision to Diff 33629.
davidedmundson added a comment.
Remove debug
stupid arc. Spend ages selectively choosing the hunks I want, and then it
goes and adds them
back anyway to "help".
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://ph
davidedmundson updated this revision to Diff 33628.
davidedmundson added a comment.
Remove debug
stupid arc. Spend ages selectively choosing the hunks I want, and then it
goes and adds them
back anyway to "help".
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://p
davidedmundson updated this revision to Diff 33627.
davidedmundson added a comment.
Also fixes the UI on cancel
Checkable property would be updated internally on clicked, breaking our
binding and
becoming checked on clicked regardless
The background color is set by if (checked || hig
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
The current index or highlighted item in the sidebar still changes if you
Cancel in the prompt as that's done from QML
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
When you switch module with unsaved changes t
