D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. In D12606#255923 , @davidedmundson wrote: > It is not "dead" however it is now restricted to fixes for major bugs such as security and data loss. Ok, I don't think this qualifies then... REPOSITORY R120 Plasma

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread David Edmundson
davidedmundson added a comment. It is not "dead" however it is now restricted to fixes for major bugs such as security and data loss. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12606 To: wbauer, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragree

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
wbauer added a comment. Forgot to ask: should I cherry-pick this to the 5.8 branch too? Or is that completely dead already anyway? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12606 To: wbauer, #plasma, davidedmundson Cc: ngraham, plasma-devel, ragreen,

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-30 Thread Wolfgang Bauer
This revision was automatically updated to reflect the committed changes. Closed by commit R120:608204765110: [ksmserver] Use QUrl::fromUserInput to construct sound url (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12606?vs=3330

D12606: Use QUrl::fromUserInput to construct sound url

2018-04-29 Thread Wolfgang Bauer
wbauer created this revision. wbauer added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wbauer requested review of this revision. REVISION SUMMARY Since Phonon 4.9, this code fails to play a login sound if the sound