D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cfd77db90cf6: [ContextMenu Containment Action] Fix checking for KIOSK (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12376?vs=32793&

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-23 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12376 To: broulik, #plasma, sitter Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 32793. broulik added a comment. - Check both in run command REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12376?vs=32635&id=32793 REVISION DETAIL https://phabricator.kde.org/D12376 AFFECTED FILES contain

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-20 Thread Harald Sitter
sitter added a comment. The logout change seems fine. WRT run_command I wonder if it wouldn't be better to keep this backwards compatible `authorize(run_command) && authorizeAction(run_command)`. If a user previously restricted **only** `actions/run_command` that would, with the current

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

2018-04-20 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Anyone else checks for `run_command`. Docs explicitly menti