D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-20 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:442cf697be51: Use consistent spacing and units for suffixes in spinboxes (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12137?vs=32427

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-20 Thread Albert Astals Cid
aacid added a comment. yeah i think that's easier to understand REPOSITORY R114 Plasma Addons BRANCH fixsecondssuffix REVISION DETAIL https://phabricator.kde.org/D12137 To: kossebau, #plasma, #localization, davidedmundson Cc: aacid, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBo

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. @aacid Does the new context pattern "spacing to number + unit" make more sense to you (and remind you less of sad things ) )? Would then push this otherwise now, given that the new proposed context UI marker will be only really available once 4.46 is out, so it

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-17 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 32427. kossebau added a comment. try other context pattern: spacing to number + unit REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12137?vs=31945&id=32427 BRANCH fixsecondssuffix REVISION DETAIL https://ph

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-17 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D12137#245104 , @aacid wrote: > is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book". Good question. I run chance of creat

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-12 Thread Albert Astals Cid
aacid added a comment. is appendix something people would understand? because for me is "the things that kills you if you're unlucky", "the end chapter of a book". REPOSITORY R114 Plasma Addons BRANCH fixsecondssuffix REVISION DETAIL https://phabricator.kde.org/D12137 To: kossebau, #

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-12 Thread Friedrich W . H . Kossebau
kossebau added a comment. @davidedmundson Thanks for review. Delaying push of this patch though for now a little, until https://marc.info/?l=kde-i18n-doc&m=152354758527289&w=2 ("RFC: Notation of numbers with (physical) units/symbols") has been discussed with a result REPOSITORY R114 Plas

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-12 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems we do this in designer files for QWidget spinboxes too. REPOSITORY R114 Plasma Addons BRANCH fixsecondssuffix REVISION DETAIL https://phabricator.kde.org/D12137

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-11 Thread Friedrich W . H . Kossebau
kossebau added a comment. Is there any mention about unit symbols appending in the HIG? Would be interesting to know what for consistent UI is recommended e.g. for "days", where some are used to "d" as unit, while the mere mortal might be more familiar/comfortable with "days" in the UI of th

D12137: Use consistent spacing and units for suffixes in spinboxes

2018-04-11 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, kde-i18n-doc. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY As specified by the International System of Units