D12103: Support snap permissions in Discover

2019-08-13 Thread Juan Asensio Sánchez
juanasensiosanchez added a comment. That makes sense: $ dpkg -l | grep discover ii avahi-utils 0.7-3.1ubuntu1.2 amd64Avahi browsing, publishing and discovery utilities ii plasma-discover

D12103: Support snap permissions in Discover

2019-08-13 Thread Nathaniel Graham
ngraham added a comment. Kubuntu 18.04 uses Plasma 5.12 which includes Discover 5.12. This code was added in a later version (likely 5.13). REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: juanasensiosanchez, ngraham, plasma-devel,

D12103: Support snap permissions in Discover

2019-08-13 Thread Juan Asensio Sánchez
juanasensiosanchez added a comment. New in Phabricator. Is this code already merged? Using Kubuntu 18.04 with Backports PPA but I can't see these options. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: juanasensiosanchez, ngraham,

D12103: Support snap permissions in Discover

2018-04-11 Thread Aleix Pol Gonzalez
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:0376a9727e53: Support snap permissions in Discover (authored by apol). REPOSITORY R134 Discover Software Store CHAN

D12103: Support snap permissions in Discover

2018-04-11 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 31911. apol added a comment. Address issues by upstreap snapdqt maintainer Robert Ancell. Change to show a check box instead of the slider. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12103?vs=31847&id

D12103: Support snap permissions in Discover

2018-04-10 Thread Nathaniel Graham
ngraham added a comment. Also those labels are not very descriptive; are there better strings available? Looking at the screenshots, I have no idea what most of those permissions actually do. A regular user would be even more confused. REPOSITORY R134 Discover Software Store REVISION DETA

D12103: Support snap permissions in Discover

2018-04-10 Thread Nathaniel Graham
ngraham added a comment. +1 for the feature, but could we use checkboxes instead of toggles? I'm not real thrilled with the ones in those screenshots. It's not at all clear what's on and what's off. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D121

D12103: Support snap permissions in Discover

2018-04-10 Thread Aleix Pol Gonzalez
apol added a comment. F5803518: Screenshot_20180411_024622.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12103: Support snap permissions in Discover

2018-04-10 Thread Aleix Pol Gonzalez
apol added a comment. F5803515: Screenshot_20180411_024501.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D12103 To: apol Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12103: Support snap permissions in Discover

2018-04-10 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D12103 AFFECTED FI