D12083: Show OSD when default output changes

2018-04-10 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R115:893ee005b120: Show OSD when default output changes (authored by broulik). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12083?vs=31800&id=31804

D12083: Show OSD when default output changes

2018-04-10 Thread Kai Uwe Broulik
broulik updated this revision to Diff 31800. broulik edited the test plan for this revision. broulik added a comment. - Use default sink instead of preferred sink as the latter also changes depending on where music is being played REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LA

D12083: Show OSD when default output changes

2018-04-10 Thread David Edmundson
davidedmundson added a comment. Very nice +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D12083 To: broulik, #plasma, #vdg, drosca Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D12083: Show OSD when default output changes

2018-04-10 Thread David Rosca
drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ListItemBase.qml:284 > menuItem.clicked.connect(function() { > +paSinkModel.pendingPreferredSinkChange = true; >

D12083: Show OSD when default output changes

2018-04-10 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the default output changes because a device is pl