This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on
Refresh/Reload (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11955?vs=32995&id=33
broulik updated this revision to Diff 32995.
broulik edited the summary of this revision.
broulik added a comment.
This revision is now accepted and ready to land.
- Drop "reload" action
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11955?vs=31383&i
broulik planned changes to this revision.
broulik added a comment.
I just noticed that `setUsedByContainment` actually renames the "reload"
action to "Refresh desktop", so "refresh" is essentially useless.
Will refactor this to get rid of the dedicated "Refresh" action and just use
"Reload"
hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
Could you add a code comment about why this is not an issue, similar to the
description? If two far-removed places of code depend on each other indirectly
and by design it warrants a comment so
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
While both actions are added to the collection, only one is s
