D11748: Assign notification area category

2019-12-08 Thread Nathaniel Graham
ngraham closed this revision. ngraham added a comment. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Z

D11748: Assign notification area category

2019-12-08 Thread Aleix Pol Gonzalez
apol added a comment. Already landed https://cgit.kde.org/kdeplasma-addons.git/commit/?id=d744370117bef4384bbd0e92fbcee4805169acaa REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngra

D11748: Assign notification area category

2019-12-05 Thread Nathaniel Graham
ngraham added a comment. You can see the name at https://cgit.kde.org/plasma-desktop.git/commit/?id=1db79dc54c464d159d4ff8e8c91452758c9aa220 REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: ap

D11748: Assign notification area category

2019-12-05 Thread Aleix Pol Gonzalez
apol added a comment. Yes, I'd say so. wsdfhjxc, can you please give us your name to properly track the copyright of the line? REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc: apol, ngrah

D11748: Assign notification area category

2019-12-05 Thread Nathaniel Graham
ngraham added a subscriber: apol. ngraham added a comment. @apol does this still make sense to do in `org.kde.discover.notifier.desktop.cmake`? REPOSITORY R134 Discover Software Store BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11748 To: wsdfhjxc, #plasma, ngraham Cc:

D11748: Assign notification area category

2018-03-27 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense, but let's only commit if and when D11352 goes in, since it doesn't make sense without it. REPOSITORY R134 Discover Software Store BRA

D11748: Assign notification area category

2018-03-27 Thread Wojciech Stachurski
wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352