D11739: Use platform detection from KWorkSpace in KCMShell

fvogt added a comment. In D11739#235478 , @bcooksley wrote: > Please update the dependency metadata in kde-build-metadata. > This has broken the CI builds for kde-cli-tools on all platforms. The issue here is that plasma-workspace requ

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt added a comment. > Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later. Ok, done. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley,

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Please update the dependency metadata in kde-build-metadata. This has broken the CI builds for kde-cli-tools on all platforms. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley, roma

D11739: Use platform detection from KWorkSpace in KCMShell

This revision was automatically updated to reflect the committed changes. Closed by commit R126:896dd5516cfb: Use platform detection from KWorkSpace in KCMShell (authored by fvogt). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11739?vs=30731&id=307

D11739: Use platform detection from KWorkSpace in KCMShell

bcooksley added a comment. Thanks, I've initiated rebuilds of kde-cli-tools now. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma, romangg Cc: bcooksley, romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterbe

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt updated this revision to Diff 30731. fvogt added a comment. Do the same as krunner, unset the variable if platform got detected. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11739?vs=30697&id=30731 BRANCH master REVISION DETAIL https

D11739: Use platform detection from KWorkSpace in KCMShell

romangg added a comment. Unset the variable again after app call just to make sure? REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D11739 To: fvogt, #plasma Cc: romangg, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D11739: Use platform detection from KWorkSpace in KCMShell

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY In a Wayland session, KCMs need to use the wayland platform plugin. TEST PLAN kcmshell5 kscreen now works properly. REPOSITOR