D11663: Add InlineMessage type and Gallery app example page

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e6231547df6d: Add InlineMessage type and Gallery app example page (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30835&id=30836 REVIS

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30835. hein added a comment. - Make icon a grouped property. - Support icon color tinting. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30781&id=30835 BRANCH master REVISION DETAIL https://phabricator.k

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30781. hein added a comment. Be opportunistic and rename InlineMessageType to MessageType. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30710&id=30781 BRANCH master REVISION DETAIL https://phabricator.kde

D11663: Add InlineMessage type and Gallery app example page

hein added inline comments. INLINE COMMENTS > mart wrote in enums.h:39 > please call this in a more generic way, like MessageSeverity, so can be used > for other kinds of messages if needed, like passivenotification and inline > dialogs Hang on, I focused on disagreeing with Severity, but I un

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. A screenshot including the new dialog-positive icon made by the VDG: F5769344: inlinemessages7.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: davidedmundson, n

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30710. hein marked an inline comment as done. hein added a comment. - Use the new dialog-positive icon (thanks VDG!) for Kirigami.InlineMessageType.Positive. - Flesh out the Gallery example page info text and give it a nicer heading. REPOSITORY R169 Kiri

D11663: Add InlineMessage type and Gallery app example page

hein marked 5 inline comments as done. hein added inline comments. INLINE COMMENTS > mart wrote in InlineMessage.qml:91 > this would make opacity of contentitem 1.0 even when animationg to 0? No, because of `enabled: !root.visible`. implicitHeight is bound to an expression that's recomputed whe

D11663: Add InlineMessage type and Gallery app example page

mart added inline comments. INLINE COMMENTS > hein wrote in InlineMessage.qml:100 > Can you give me a code example of how to use this in the template code? as Action.qml is doing: this is how Action uses it: property ActionIconGroup icon: ActionIconGroup { id: iconGroup } ActionIconGr

D11663: Add InlineMessage type and Gallery app example page

hein marked 4 inline comments as done. hein added inline comments. INLINE COMMENTS > mart wrote in InlineMessagesGallery.qml:61 > add some usage explanation here, like that should be added in the main layout > of the ui you want to put it in, that is not visible by default, needing an > explici

D11663: Add InlineMessage type and Gallery app example page

mart added inline comments. INLINE COMMENTS > InlineMessagesGallery.qml:61 > +wrapMode: Text.WordWrap > +text: "Inline messages allow you to show various types of > messages without an overlay dialog." > +} add some usage explanation here, like that should be add

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. I've filed a bug against the Breeze icon theme to sort out the icon issues this new component poses: https://bugs.kde.org/show_bug.cgi?id=392391 This should not affect this review, though. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11

D11663: Add InlineMessage type and Gallery app example page

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in InlineMessage.qml:225-226 > I don't think either of these two lines will work as you intend as you've not > constrained the label height anywhere For some reason this did "work" in the gallery in the sense that the visual re

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30692. hein marked an inline comment as done. hein added a comment. Fix wrong approach to aligning the text as pointed out by David. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30603&id=30692 BRANCH master

D11663: Add InlineMessage type and Gallery app example page

davidedmundson added a comment. Very nice! INLINE COMMENTS > InlineMessage.qml:225-226 > +wrapMode: Text.WordWrap > +elide: Text.ElideRight > +verticalAlignment: lineCount > 1 ? Qt.AlignVCenter : > Qt.AlignTop > + I don't think either of these

D11663: Add InlineMessage type and Gallery app example page

hein added subscribers: broulik, ngraham. hein added a comment. Adding back subscribers, sorry, my arc invocation to do the above removed you. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: ngraham, broulik, plasma-devel, apol, d

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30603. hein edited the summary of this revision. hein removed subscribers: broulik, ngraham. hein added a comment. Minor fixes to commit message & mention more compact layout; sync summary. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabr

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30602. hein added a comment. Drop noisy debug from Kai's findIndex. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30601&id=30602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED F

D11663: Add InlineMessage type and Gallery app example page

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessage.qml:364 > `findIndex` is new in Qt 5.9 > > [1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html Switched to homebrew implementation from your D11707

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30601. hein added a comment. Use homebrew findIndex from D11707 to lower deps below Qt 5.9. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30599&id=30601 BRANCH master RE

D11663: Add InlineMessage type and Gallery app example page

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessagesGallery.qml:115 > There's no `start-here` in Breeze, just `start-here-kde` which won't fall > back to `start-here` (which is distro-branded for you apparently) Replaced with syste

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30599. hein added a comment. Use more generic icon as custom icon example. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30596&id=30599 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFF

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30596. hein marked 5 inline comments as done. hein added a comment. - Correct gallery page heading (note to Marco: also wrong in one of the Cards gallery pages). - Use hasOwnProperty. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabrica

D11663: Add InlineMessage type and Gallery app example page

hein marked 5 inline comments as done. hein added inline comments. INLINE COMMENTS > broulik wrote in InlineMessagesGallery.qml:45 > Wrong class name Thanks, will fix. > broulik wrote in InlineMessagesGallery.qml:115 > There's no `start-here` in Breeze, just `start-here-kde` which won't fall >

D11663: Add InlineMessage type and Gallery app example page

broulik added inline comments. INLINE COMMENTS > InlineMessagesGallery.qml:45 > +Layout.fillWidth: true > +text: "CardsLayout" > +} Wrong class name > InlineMessagesGallery.qml:115 > + > +icon: "start-here" > + There's no `start-here` in

D11663: Add InlineMessage type and Gallery app example page

broulik added a comment. Sweet INLINE COMMENTS > InlineMessage.qml:364 > + > +visible: > actionsLayout.overflowSet.findIndex(function(act) { > +return act == modelData}) > -1 && > modelData.visible `findIndex` is new in Qt 5.9 [1

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. After everyone I talked to universally preferring this option, the code in the latest diff now produces this: F5767042: inlinemessages6.png I'm out of todos on this, so please review now! REPOSITORY R169 Kirigami REVISI

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30594. hein added a comment. - Switch to the rounded border + pale fill style most people seem to prefer. This is a proper implementation with better inside corners and the border width matching the seperator width. The radius is the same as for passive not

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30458. hein added a comment. Remove unrelated files. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30446&id=30458 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED FILES examples

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. I have no strong preference as far as the visuals are concerned. I would be OK with the rounded + colored version, too. It's also fairly close to KMessageWidget, which would make it quite easy to make KMessageWidget look similar (other than spacing). If this version ach

D11663: Add InlineMessage type and Gallery app example page

ngraham added a comment. Big +1 on the version with the colored borders and background. That looks really classy IMHO. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30446. hein added a comment. Get rid of an unnecessary extra Rectangle. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30445&id=30446 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECT

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Quick hacks for alternate appearances based on VDG chat brainstorming: F5765210: inlinemessages4.png F5765212: inlinemessages5.png On this last one the inside corners are not prope

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30445. hein added a comment. Don't use redundant default value in API documentation code example. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30444&id=30445 BRANCH master REVISION DETAIL https://phabrica

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30444. hein added a comment. Add more defaults to API documentation. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30442&id=30444 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 AFFECTED

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Additional note: The missing icons in the Material Gallery screenshot are because the Gallery app build system seems to refuse to extract them from Breeze for unknown reasons (perhaps missing sizes). REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. This component is needed to complete task T7247 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11663 To: hein, #kirigami, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

hein updated this revision to Diff 30442. hein added a comment. Fix typo in Gallery error message example text. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11663?vs=30441&id=30442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11663 A

D11663: Add InlineMessage type and Gallery app example page

hein added a comment. Kirigami Gallery app, desktop style: F5765163: inlinemessages1.png Kirigami Gallery app, desktop style, after the actions are used: F5765167: inlinemessages2.png Kirigami Gall

D11663: Add InlineMessage type and Gallery app example page

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY InlineMessage can be used to show various messages to the user,