D11375: Don't block evaluating DBus scripts if widgets are locked.

Zren added a comment. Um, `if (immutability() != Plasma::Types::SystemImmutable) { return; }` was pushed. You're last revision https://phabricator.kde.org/D11375?id=30006 had it correctly. `if (immutability() == Plasma::Types::SystemImmutable) { return; }` REPOSITORY R120 Plasma Work

D11375: Don't block evaluating DBus scripts if widgets are locked.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddf452b6774f: Don't block evaluating DBus scripts if widgets are locked. (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11375?vs=30006&id=30008#toc REPOSITORY R

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson updated this revision to Diff 30006. davidedmundson added a comment. How embarassing :/ REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11375?vs=29991&id=30006 REVISION DETAIL https://phabricator.kde.org/D11375 AFFECTED FILES sh

D11375: Don't block evaluating DBus scripts if widgets are locked.

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Now you block everything but when system immutable REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11375 To: davidedmundson, #plasma, broulik

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson updated this revision to Diff 29991. davidedmundson added a comment. system immutable check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11375?vs=29650&id=29991 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11375

D11375: Don't block evaluating DBus scripts if widgets are locked.

mart added a comment. In D11375#227088 , @broulik wrote: > Please change the check to be > > if (immutability() == Plasma::Types::SystemImmutable) { > ... > return; > } > > > we don't want to introduce a way to mess

D11375: Don't block evaluating DBus scripts if widgets are locked.

broulik added a comment. Please change the check to be if (immutability() == Plasma::Types::SystemImmutable) { ... return; } we don't want to introduce a way to mess up sysadmin-confined setups this way. REPOSITORY R120 Plasma Workspace REVISION DETAIL http

D11375: Don't block evaluating DBus scripts if widgets are locked.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Original decision didn't really have a ration