D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. Not so sure why phabricator didn't set you as the commit author... sorry about that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliez

D11061: Migration request from IBusConfig to GSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e2a29f8ea072: Migration request from IBusConfig to GSettings (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28920&id=2896

D11061: Migration request from IBusConfig to GSettings

fujiwara updated this revision to Diff 28920. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28881&id=28920 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara, #pl

D11061: Migration request from IBusConfig to GSettings

xuetianweng added inline comments. INLINE COMMENTS > panel.cpp:922 > +impanel_update_engines(impanel, var_engines); > +if (var_engines) > +g_variant_unref(var_engines); https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces Always use braces > panel.cpp:933 > +impan

D11061: Migration request from IBusConfig to GSettings

fujiwara added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem I may drop gconf and dconf support in IBus 1.6. It would be nice if Qt API could read GSettings. REPOSI

D11061: Migration request from IBusConfig to GSettings

fujiwara marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

fujiwara updated this revision to Diff 28881. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28793&id=28881 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara, #pl

D11061: Migration request from IBusConfig to GSettings

xuetianweng requested changes to this revision. xuetianweng added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > panel.cpp:1049 > +g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, > (gpointer)impanel_settings_changed_callback, impanel); > +

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem imho, this is pretty irrelevant here.. gsettings is not directly gconf and gconf itself is deprecated

D11061: Migration request from IBusConfig to GSettings

davidedmundson added a comment. FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, j

D11061: Migration request from IBusConfig to GSettings

fujiwara requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

fujiwara updated this revision to Diff 28793. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28722&id=28793 REVISION DETAIL https://phabricator.kde.org/D11061 AFFECTED FILES applets/kimpanel/backend/ibus/ibus15/panel.cpp To: fujiwara, #pl

D11061: Migration request from IBusConfig to GSettings

fujiwara planned changes to this revision. fujiwara marked 2 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D11061: Migration request from IBusConfig to GSettings

xuetianweng added inline comments. INLINE COMMENTS > panel.cpp:1031 > impanel->xkbLayoutManager = new XkbLayoutManager; > +impanel->settings_general = g_settings_new (IBUS_SCHEMA_GENERAL); > +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY); IMHO you need to g_object_u

D11061: Migration request from IBusConfig to GSettings

xuetianweng requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D11061: Migration request from IBusConfig to GSettings

fujiwara added a comment. In D11061#219603 , @xuetianweng wrote: > May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work? > > If so I'd like to see a version check o

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work? If so I'd like to see a version check on ibus at compile time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D11061: Migration request from IBusConfig to GSettings

cfeck added a reviewer: xuetianweng. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

lbeltrame added reviewers: Plasma, hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11061: Migration request from IBusConfig to GSettings

fujiwara created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. fujiwara requested review of this revision. REVISION SUMMARY kimpanel-ibus-panel uses IBusConfig and I'd ask to migrate it to GSettings and delete IBusConfig.