D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R114:1319b7bfe892: [grouping applet] Add missing Comment entry to metadata (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10793?vs=27915&id=27925#toc REPOSITORY R114 Plasm

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D10793#212670 , @davidedmundson wrote: > Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc. Given I just copied the same string as used for the metadata of the internal grouping package and

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Changing i18n in stable as a bug fix is allowed, but CC kde-i18n-doc. > Has there been already a request for a custom icon be filed Don't think so REPOSITORY R114

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau added a comment. Noticed the comment missing in the "Add widget.." picker, appstreamcli also complains about missing summary entry. I picked the string as used with the private implementation version of that widget (no clue on the details though). Fix would be for 5.12 bran

D10793: [grouping applet] Add missing Comment entry to metadata

2018-02-24 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH fixgroupingmissingcomment REVIS