This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:79fb4ebfa77f: other preload microoptimizations (authored
by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANG
broulik accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D10722
To: mart, #plasma, davidedmundson, broulik
Cc: davidedmundson, broulik, plasma-devel, #frameworks, michaelh, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts
mart updated this revision to Diff 27798.
mart added a comment.
- err forgot typeof
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10722?vs=27797&id=27798
BRANCH
arcpatch-D10722
REVISION DETAIL
https://phabricator.kde.org/D10722
AF
mart updated this revision to Diff 27797.
mart added a comment.
- fix typo
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10722?vs=27796&id=27797
BRANCH
arcpatch-D10722
REVISION DETAIL
https://phabricator.kde.org/D10722
AFFECTED FI
mart updated this revision to Diff 27796.
mart added a comment.
- check for function
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10722?vs=27795&id=27796
BRANCH
arcpatch-D10722
REVISION DETAIL
https://phabricator.kde.org/D10722
A
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in svgitem.cpp:50
> > when the component is complete, in many cases i guessthe properties would
> > all be already set?
>
> We know for definitely they will be already set.
>
> I don't understand what problem you think this is
mart updated this revision to Diff 27795.
mart added a comment.
- Revert most of it
- only leave the forcelayout part
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10722?vs=27707&id=27795
BRANCH
arcpatch-D10722
REVISION DETAIL
ht
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> mart wrote in svgitem.cpp:50
> when the component is complete, in many cases i guessthe properties would all
> be already set? (could add a ch
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in svgitem.cpp:50
> I don't see how this makes any difference.
>
> Every setSomeProperty already calls scheduleImageUpdate regardless of whether
> we're complete or not.
> and if you don't have any properties set, then there's n
davidedmundson added inline comments.
INLINE COMMENTS
> svgitem.cpp:50
>
> +void SvgItem::componentComplete()
> +{
I don't see how this makes any difference.
Every setSomeProperty already calls scheduleImageUpdate regardless of whether
we're complete or not.
and if you don't have any propert
broulik added inline comments.
INLINE COMMENTS
> iconitem.h:42
> Q_OBJECT
> +Q_INTERFACES(QQmlParserStatus)
>
`QQuickItem` should do that for you already
> svgitem.h:41
> Q_OBJECT
> +Q_INTERFACES(QQmlParserStatus)
>
Same here
> ScrollArea.qml:58
> +Component.onComple
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
make svgitem schedule a polish right when it's done l
12 matches
Mail list logo
