D10605: Fix location of Firefox dbCacheFile

This revision was automatically updated to reflect the committed changes. Closed by commit R120:745cffc9ffd3: Fix location of Firefox dbCacheFile (authored by z3ntu, committed by mlaurent). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10605?vs=27414

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Ok I will commit for you. Regards REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. No (this is one of my first patches 😄) REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

mlaurent added a comment. Do you have commit access ? REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali

D10605: Fix location of Firefox dbCacheFile

z3ntu marked an inline comment as done. z3ntu added a comment. @mlaurent Updated the patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10605: Fix location of Firefox dbCacheFile

z3ntu updated this revision to Diff 27414. z3ntu added a comment. Put slash directly into the QStringLiteral REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10605?vs=27403&id=27414 BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D106

D10605: Fix location of Firefox dbCacheFile

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Otherwise patch is correct. INLINE COMMENTS > firefox.cpp:58 > if (m_dbCacheFile.isEmpty()) { > -m_dbCacheFile = > QStandardPaths::writableLocation(QStandardPath

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. I researched a bit more. The commit af0a29a185f190088af4a3a9d0d5bfb28a8feae3 caused this behaviour. A small test app results in: > Before: "/home/luca/.cache/bookmarkrunnerfirefoxdbfile.sql

D10605: Fix location of Firefox dbCacheFile

z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY Before: ~/.cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite After: ~/.cache/krunner/bookmarkrunnerfiref