This revision was automatically updated to reflect the committed changes.
Closed by commit R31:0371463b4a6f: fix double spacing bug (authored by zzag).
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10584?vs=27367&id=27391
REVISION DETAIL
https://phabricator.k
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.
Ship it !
Thanks for this patch, and sorry for the mess on the Blur patch (should have
used arc).
REPOSITORY
R31 Breeze
BRANCH
double-space-bug
REVISION DETAIL
zzag added a comment.
@hpereiradacosta: yes, you're right
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D10584
To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
zzag updated this revision to Diff 27367.
zzag added a comment.
add icon width to the contents size only if there is an icon
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10584?vs=27345&id=27367
BRANCH
double-space-bug
REVISION DETAIL
https://phabricat
hpereiradacosta added a comment.
Thanks for the patch.
I "think" one must also do a similar fix in "Style::menuItemSizeFromContents".
It seems to me that there also the line 2728
leftColumnWidth += Metrics::MenuItem_ItemSpacing;
should also be conditionned with "if iconWidth > 0"
Ca
zzag edited the summary of this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D10584
To: zzag, #breeze, #vdg, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
zzag created this revision.
zzag added reviewers: Breeze, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
zzag requested review of this revision.
REVISION SUMMARY
When a menu doesn't have any icons, space between chec
