D10549: Don't crash if the cursor theme fails to create

2018-03-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:2ea5153e1c97: Don't crash if the cursor theme fails to create (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10549?vs=27278&id=28560 REVISION

D10549: Don't crash if the cursor theme fails to create

2018-02-26 Thread Roman Gilg
romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH dont-crash-cursor-theme-failure REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma, davidedmundson, romangg Cc: romangg, plasma-devel, kwin, iodelay,

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in wayland_cursor_theme.cpp:69 > Can we check differently if it is the same theme? Or should we in any case > emit themeChanged when we are at this point already?

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Roman Gilg
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma, davidedmundson, romangg Cc: romangg, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Roman Gilg
romangg added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > graesslin wrote in wayland_cursor_theme.cpp:69 > As it returns a pointer it is impossible that we get the same pointer back. Can we check differently if it is the same theme? Or s

D10549: Don't crash if the cursor theme fails to create

2018-02-25 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > romangg wrote in wayland_cursor_theme.cpp:69 > Only do if theme really changes (`theme && m_theme != theme`). As it returns a pointer it is impossible that we get the same point

D10549: Don't crash if the cursor theme fails to create

2018-02-24 Thread Roman Gilg
romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > wayland_cursor_theme.cpp:69 > size, m_shm->shm()); >

D10549: Don't crash if the cursor theme fails to create

2018-02-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH dont-crash-cursor-theme-failure REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin,

D10549: Don't crash if the cursor theme fails to create

2018-02-21 Thread Martin Flöser
graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10549 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening,

D10549: Don't crash if the cursor theme fails to create

2018-02-15 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV