D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. normal in Latte F5713010: εικόνα.png needsattention in Latte F5713020: εικόνα.png REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.

D10516: Update status to NeedsAttention when there is a menu

mvourlakos closed this revision. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. merged with: https://commits.kde.org/plasma-active-window-control/d07bd170d39adab35b7861ab6c480286a4d0253e REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, p

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206606 , @martinkostolny wrote: > thanks! fatal: remote error: service not enabled: /plasma-active-window-control unfortunately I can commit, I get: fatal: remote error: service not enable

D10516: Update status to NeedsAttention when there is a menu

martinkostolny accepted this revision. martinkostolny added a comment. thanks! REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206458 , @broulik wrote: > Oh, sorry, I assumed from the name of the files it was plasma-workspace :) lgtm! :) if this is accepted, then I will try to send a fix for plasma menu also afterwards... R

D10516: Update status to NeedsAttention when there is a menu

broulik added a comment. Oh, sorry, I assumed from the name of the files it was plasma-workspace :) lgtm! REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, plasma-devel, ZrenBot, progwol

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206437 , @martinkostolny wrote: > Thanks for fixing my code! :) can you please confirm also the update that follows @broulik suggestion? I confirmed with Latte that everything works flawlessly now.

D10516: Update status to NeedsAttention when there is a menu

mvourlakos updated this revision to Diff 27186. mvourlakos added a comment. followed @broulik suggestions and added also an improvement to not update menu index all the time when changing from menu to menu REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D10516: Update status to NeedsAttention when there is a menu

martinkostolny accepted this revision. martinkostolny added a comment. This revision is now accepted and ready to land. Thanks for fixing my code! :) I'm sure I can also provide a flag for menu availability (the code for appmenu is copied for now anyway). But I think in AWC it does not ma

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206373 , @broulik wrote: > Thanks for looking into this! > > I could prefer a QML binding that also takes into account wheter there is a menu at all, something like > > Plasmoid.status: { >

D10516: Update status to NeedsAttention when there is a menu

broulik added a comment. Thanks for looking into this! I could prefer a QML binding that also takes into account wheter there is a menu at all, something like Plasmoid.status: { if (currentIndex > -1) { return PlasmaCore.Types.NeedsAttentionStatus; } els

D10516: Update status to NeedsAttention when there is a menu

mvourlakos edited the test plan for this revision. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ma

D10516: Update status to NeedsAttention when there is a menu

mvourlakos created this revision. mvourlakos added a reviewer: martinkostolny. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY Following the discussion at: https://github.com/