D10490: Add a method to dbus interface to query information about a window

This revision was automatically updated to reflect the committed changes. Closed by commit R108:1d71292e13fc: Add a method to dbus interface to query information about a window (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHA

D10490: Add a method to dbus interface to query information about a window

romangg accepted this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH rules-detect-dbus REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma, davidedmundson, romangg Cc: davidedmundson, broulik, plasma-d

D10490: Add a method to dbus interface to query information about a window

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH rules-detect-dbus REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma, david

D10490: Add a method to dbus interface to query information about a window

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma Cc: davidedmundson, broulik, plasma-devel, kwin, iodelay, bwowk, ZrenBot, lesliezhai,

D10490: Add a method to dbus interface to query information about a window

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10490 To: graesslin, #kwin, #plasma Cc: davidedmundson, broulik, plasma-devel, kwin, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, m

D10490: Add a method to dbus interface to query information about a window

graesslin marked an inline comment as done. graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > davidedmundson wrote in dbusinterface.cpp:193 > can you add: > > if (m_replyQuery...) {sendError()} > > otherwise if a user makes tw

D10490: Add a method to dbus interface to query information about a window

graesslin updated this revision to Diff 27318. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Remove unneeded comment REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10490?vs=27094&id=27318 BRANCH rules-detect-

D10490: Add a method to dbus interface to query information about a window

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > broulik wrote in dbusinterface.cpp:199 > Can you use introspection to fill this `QVariantMap` rather than manually > doing this? We don't have properties for all of them and it

D10490: Add a method to dbus interface to query information about a window

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Cool approach. One minor thing that won't happen anyway. INLINE COMMENTS > dbusinterface.cpp:193 > +{ > +m_replyQueryWindowInfo = message(); > +setDelayedReply(true); can you add: if

D10490: Add a method to dbus interface to query information about a window

broulik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > dbusinterface.cpp:199 > +const QVariantMap ret{ > +{QStringLiteral("resourceClass"), c->resourceClass()}, > +{QStringLiteral

D10490: Add a method to dbus interface to query information about a window

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV