D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-06 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7abd8d0da447: Fix dupe handling in requestAddLauncherToActivities; improve unit test (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D102

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-06 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for after 5.12.0 but good for backport REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10253 To: hein, #plasma, mart Cc: mart, plasma-de

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-05 Thread Friedrich W . H . Kossebau
kossebau resigned from this revision. kossebau added a comment. Tried few times to grasp all the related code to give this some insightful review, but always ran out of time. Sadly not qualitfied to review this code in reasonable amount of time. At least triggered some general quality fixes

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

2018-02-02 Thread Eike Hein
hein created this revision. hein added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The business logic was using the resolved URL in lookups in internal data structures, instead of the internal key it pr