Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
gt; > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial port to frameworks. > > > Diffs > - > &

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
marked as submitted. Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread David Edmundson
ed e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Oct. 17, 2014, 12:08 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastia

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-12-23 Thread Marco Martin
isit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Oct. 17, 2014, 12:08 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > >

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-12-13 Thread Andrei Amuraritei
> > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial port to frameworks. > > > Diffs > - &

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-12-11 Thread Marco Martin
gt; (Updated Oct. 17, 2014, 12:08 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial port to fr

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-17 Thread Martin Klapetek
- > > (Updated Oct. 17, 2014, 2:08 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial por

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
Edmundson, Marco Martin, Martin Klapetek, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
0276/ > ------- > > (Updated Oct. 17, 2014, 2:59 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > -

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-16 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fix Martin Klapetek reported issues. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs (updated) - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-13 Thread Martin Klapetek
is is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Oct. 12, 2014, 6:06 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-12 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-10-12 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Working version of dataengine and patch applying. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs (updated) - dataengines/comic/comicproviderkross.h 46a9072 dataengines

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-20 Thread Martin Klapetek
> https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 9:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > D

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-20 Thread Bhushan Shah
iewboard.kde.org/r/120276/ > --- > > (Updated Sept. 20, 2014, 12:47 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > >

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Martin Klapetek
lly generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 9:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügl

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
d.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 10:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Desc

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
atically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 10:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > &

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Martin Klapetek
> (Updated Sept. 19, 2014, 9:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > > comic DataEngine initial port to frameworks. > > >

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
rated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 10:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > >

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fixed issues specified. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs (updated) - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Martin Klapetek
git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 9:15 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description &g

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Changes --- Fix issues specified. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Martin Klapetek
il. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > --- > > (Updated Sept. 19, 2014, 6:53 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addo

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-19 Thread Martin Klapetek
> > (Updated Sept. 19, 2014, 6:53 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > --- > >

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2014-09-18 Thread Andrei Amuraritei
Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/CMakeLists.txt 04c7985 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.h baac8a9 dataengines

Re: Problems with KService/KBuildSycoca in Comic Dataengine

2011-07-27 Thread Matthias Fuchs
recreate() via dbus > when a package is installed. > > does the attached patch to libplasma fix it for you? Thank you a lot for you patch! I just realised that the initial problem was an embarrassing long lasting issue in the comic dataengine. We never called DataEngine::removeAllData. No

Re: Problems with KService/KBuildSycoca in Comic Dataengine

2011-07-25 Thread Aaron J. Seigo
On Monday, July 25, 2011 17:34:05 Matthias Fuchs wrote: > plasmapkg -t comic -u %f && kbuildsycoca4 that could well be a reasonable short term solution. another would be to patch Package::installPackage to call recreate() via dbus when a package is installed. does the attached patch to libplasm

Re: Problems with KService/KBuildSycoca in Comic Dataengine

2011-07-25 Thread Matthias Fuchs
Am 25.07.2011 10:59, schrieb Aaron J. Seigo: > On Sunday, July 24, 2011 12:35:05 Matthias Fuchs wrote: >> Both have to do with KServiceTypeTrader > > it's probably kbuildsycoca and kded, not KSTT. Yes indeed. > when a comic is installed or removed, kbuildsycoca4 must be run; this will > automati

Re: Problems with KService/KBuildSycoca in Comic Dataengine

2011-07-25 Thread Aaron J. Seigo
On Sunday, July 24, 2011 12:35:05 Matthias Fuchs wrote: > Both have to do with KServiceTypeTrader it's probably kbuildsycoca and kded, not KSTT. when a comic is installed or removed, kbuildsycoca4 must be run; this will automatically happen after some delay as kded4 watches the contents. a run

Problems with KService/KBuildSycoca in Comic Dataengine

2011-07-24 Thread Matthias Fuchs
Hi, The comic dataengine has some [1] problems with sycoca for quite some time. That means that sometimes (not reproduceable on every machine and not always reproduceable) newly installed comic plugins do not show up or removed comic plugins still show up. Both have to do with

Re: Comic dataengine

2008-08-20 Thread Matthias Fuchs
Thank you for your answer Aaron, that helped me a lot. :) I'm a Qt and KDE coding newbie, so could someone of you please look at my code and comit -- I have no svn account -- it if everything is alright? I also attached the correspondence I had with the creator of "Shit Happens!" as you (Aaro

Re: Comic dataengine

2008-08-20 Thread Aaron J. Seigo
On Wednesday 20 August 2008, Matthias Fuchs wrote: > Yet I have no clue how to combine two pictures in one QImage -- if that > is even possible -- especially if one is wider than the other. open a QPainter on the one image, and paint the other one into it. if you need to combine the two of them v

Comic dataengine

2008-08-20 Thread Matthias Fuchs
Hello, I created a dataengine for the German "Shit Happens!" comic situated at www.ruth.de and got the permission by the author to publish the code. Though there is one problem left I can't solve and need your help with. He wrote that over every comic there should be this banner [1] so that