Re: Code defects in Plasma

2008-09-22 Thread Aaron J. Seigo
On Monday 22 September 2008, Ivan Čukić wrote: > > - amarok/src/context/plasma/animator.cpp:291 > > Division by 0 if frames < 3 > > issue1.diff attached hm.. i'm not even sure that '/ 3' is really needed anymore at all. or the '/ 5' elsewhere as well.. i think it actually should be: qMax(1, fram

Re: Code defects in Plasma

2008-09-22 Thread Alex Merry
On Monday 22 September 2008 11:40:14 Ivan Čukić wrote: > > - amarok/src/context/plasma/animator.cpp:291 > > Division by 0 if frames < 3 > > issue1.diff attached No-brainer. > > > - amarok/src/context/plasma/containment.cpp:991 > > Line 986 indicates that focusedApplet can be NULL. But focusedAppl

Re: Code defects in Plasma

2008-09-22 Thread Ivan Čukić
> - amarok/src/context/plasma/animator.cpp:291 > Division by 0 if frames < 3 issue1.diff attached > - amarok/src/context/plasma/containment.cpp:991 > Line 986 indicates that focusedApplet can be NULL. But focusedApplet is > equal to applet. Therefore applet can be NULL here. This is in Containmen

Code defects in Plasma

2008-09-22 Thread Mark Kretschmann
Hey guys, a friendly person sent us a code defect analysis for Amarok (created by an internal IBM tool). As we also import libplasma in Amarok 2, these two defects were revealed: - amarok/src/context/plasma/animator.cpp:291 Division by 0 if frames < 3 - amarok/src/context/plasma/containment.cpp: