D28132: [Calculator Runner] Minor code optimisation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28132?vs=77945&id=7

D28132: [Calculator Runner] Minor code optimisation

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Remove redunant QString::contains() checks. Create one QRegularExpression object and use setPattern(). TEST PLAN make

D4290: [Calculator Runner] Use "approximate" approximation mode

lueck added a comment. OK from german team REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: lueck, yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D4290: [Calculator Runner] Use "approximate" approximation mode

yurchor added a comment. In https://phabricator.kde.org/D4290#98033, @broulik wrote: > @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. >

D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a subscriber: kde-i18n-doc. broulik added a comment. @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. Initially it would have be

D4290: [Calculator Runner] Use "approximate" approximation mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:df7f1ed1eb7d: [Calculator Runner] Use "approximate" approximation mode (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D429

D4290: [Calculator Runner] Use "approximate" approximation mode

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-moha

[Differential] [Closed] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

This revision was automatically updated to reflect the committed changes. Closed by commit R120:605fb9acd867: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Accepted] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4472 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Request, 9 lines] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QtScript is deprecated and at least in

[Differential] [Updated, 24 lines] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik updated the summary for this revision. broulik updated this revision to Diff 10979. broulik added a comment. - Add hint when the result is an approximation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4290?vs=10577&id=10979 REVISION DETA

[Differential] [Requested Changes To] D4290: [Calculator Runner] Use "approximate" approximation mode

mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qalculate_engine.cpp:103 > +// to avoid memory overflow for seemingly innocent calculations (Bug > 277011) > +eo.approximatio

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

mart added a comment. ship it with "aproximate" text (and just 5.10) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: mart, plasma-devel

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a comment. Probably needs some indication that the result is approximate: When `result.isApproximate()` returns true I'll add a (approximation) suffix or something like this – can't go into 5.9 then. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jen

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed, jen

[Differential] [Request, 4 lines] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik created this revision. broulik added a reviewer: Plasma: Workspaces. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The runner calculator isn'

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

cfeck added a comment. The m_engine member is only available, when it uses the qalculate library instead of QScriptEngine. Please add the missing #ifdef ENABLE_QALCULATE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES

[Differential] [Closed] D1939: [Calculator Runner] Add "Copy to clipboard" action

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0abe3a6dfc24: [Calculator Runner] Add "Copy to clipboard" action (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDA

[Differential] [Accepted] D1939: [Calculator Runner] Add "Copy to clipboard" action

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

broulik added a comment. F152685: Screenshot_20160618_002329.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 24 lines] D1939: [Calculator Runner] Add "Copy to clipboard" action

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allow

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/ --- (Updated Jan. 1, 2014, 5:03 p.m.) Status -- This change has been mar

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/#review46554 --- This review has been submitted with commit efbfaf681cd4999485

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/#review46478 --- Ship it! Ship It! - David Edmundson On Dec. 31, 2013, 3:06

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/ --- (Updated Dec. 31, 2013, 3:06 a.m.) Review request for Plasma. Changes -

Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114746/ --- Review request for Plasma. Bugs: 321803 http://bugs.kde.org/show_bug.

Re: Review Request: Add libqalculate support to calculator runner

ostinelli wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3483/ > --- > > (Updated 2010-04-14 12:47:15) > >

Re: Review Request: Add libqalculate support to calculator runner

rd.kde.org/r/3483/ > --- > > (Updated 2010-04-14 12:47:15) > > > Review request for Plasma and Aaron Seigo. > > > Summary > --- > > Adds libqalculate to the default calculator runner. This enables advanced > features such as unit/currency conversion, equation s

Re: Review Request: Add libqalculate support to calculator runner

. Changes --- Fixed some whitespaces. Summary --- Adds libqalculate to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more. Diffs (updated) - /trunk/KDE/kdebase/workspace/cmake

Re: Review Request: Add libqalculate support to calculator runner

. Changes --- Implemented both changes suggested by Alessandro. Thanks! Summary --- Adds libqalculate to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more. Diffs (updated) - /trunk

Re: Review Request: Add libqalculate support to calculator runner

gt; > > Review request for Plasma and Aaron Seigo. > > > Summary > --- > > Adds libqalculate to the default calculator runner. This enables advanced > features such as unit/currency conversion, equation solving, symbolic > manipulation and more. > > > Diffs

Review Request: Add libqalculate support to calculator runner

to the default calculator runner. This enables advanced features such as unit/currency conversion, equation solving, symbolic manipulation and more. Diffs - /trunk/KDE/kdebase/workspace/cmake/modules/FindQalculate.cmake PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/generic/runners

Re: Calculator runner

t from standard output. Second, it is not easily configurable. Running bc in the background like this was why I rewrote the calculator runner to use qtscript in the first place. Rich. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/m

Re: Calculator runner

ably other reasons that I cannot remember :) That's why I started writing my own runner in playground. Moreover, the idea now is to have just a *single* calculator runner that optionally uses libqalculate. Matteo On Tue, Oct 6, 2009 at 23:04, David Baron wrote: > On Tuesday 06 October 200

Re: Calculator runner

On Tue, Oct 6, 2009 at 10:27 PM, Aaron J. Seigo wrote: > On October 6, 2009, Aleix Pol wrote: > > Well, depends a lot on how odd it is, you could install it within kdeedu > > the same way we do with the kalgebra plasmoid. There's no odd dependency > > crossing here. > > the problem would be tha

Re: Calculator runner

On Tuesday 06 October 2009 22:36:52 Aaron J. Seigo wrote: > On October 6, 2009, David Baron wrote: > > On Tuesday 06 October 2009 19:09:02 Matteo Agostinelli wrote: > > > Hello, > > > > > > as suggested by Aaron in a previous discussion, I am having a look at

Re: Calculator runner

On October 6, 2009, David Baron wrote: > On Tuesday 06 October 2009 19:09:02 Matteo Agostinelli wrote: > > Hello, > > > > as suggested by Aaron in a previous discussion, I am having a look at the > > calculator runner with the purpose of extending the capabilities

Re: Calculator runner

On October 6, 2009, Aleix Pol wrote: > Well, depends a lot on how odd it is, you could install it within kdeedu > the same way we do with the kalgebra plasmoid. There's no odd dependency > crossing here. the problem would be that we would then have two calculation plugins: one in kdebase (becau

Re: Calculator runner

On Tuesday 06 October 2009 19:09:02 Matteo Agostinelli wrote: > Hello, > > as suggested by Aaron in a previous discussion, I am having a look at the > calculator runner with the purpose of extending the capabilities of the > runner by using libqalculate when it is available... T

Re: Calculator runner

In data martedì 6 ottobre 2009 20:56:07, Aaron J. Seigo ha scritto: : > On October 6, 2009, Matteo Agostinelli wrote: > > * how should I detect the presence of qalculate on the system? Should I > > let CMake find the library and then use the preprocessor (#ifdef, ) > > thus making it a compile-

Re: Calculator runner

In data martedì 6 ottobre 2009 20:57:00, Aleix Pol ha scritto: : > Well, depends a lot on how odd it is, you could install it within kdeedu > the same way we do with the kalgebra plasmoid. There's no odd dependency > crossing here. > > Benefits, you would be using some maintained code inside KDE

Re: Calculator runner

Well, depends a lot on how odd it is, you could install it within kdeedu the same way we do with the kalgebra plasmoid. There's no odd dependency crossing here. Benefits, you would be using some maintained code inside KDE. Technically kalgebra still lacks some features though, but I'm working on i

Re: Calculator runner

On October 6, 2009, Aleix Pol wrote: > You can use KAlgebra code which is inside kdeedu. instead of libqalculate? besides creating an odd dependency, what would the benefits be? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE cor

Re: Calculator runner

On Tue, Oct 6, 2009 at 7:09 PM, Matteo Agostinelli wrote: > Hello, > > as suggested by Aaron in a previous discussion, I am having a look at the > calculator runner with the purpose of extending the capabilities of the > runner > by using libqalculate when it is available, othe

Calculator runner

Hello, as suggested by Aaron in a previous discussion, I am having a look at the calculator runner with the purpose of extending the capabilities of the runner by using libqalculate when it is available, otherwise falling back to the currently used 'qscript' method. So here are my