Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-03 Thread Aleix Pol
On Sat, Jan 3, 2015 at 12:35 AM, David Edmundson wrote: > The handler is: > > void noMessageOutput(QtMsgType type, const char *msg) > { > Q_UNUSED(type); > Q_UNUSED(msg); > } > > that's going to block warnings too. Then let's change it to: QLoggingCategory::setFilterRules(QStringLiteral

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
​The handler is: void noMessageOutput(QtMsgType type, const char *msg) { Q_UNUSED(type); Q_UNUSED(msg); } that's going to block warnings too. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 5:43 PM, David Edmundson wrote: > Won't these messages will get eaten by our noMessageOutput message handler > on login anyway? > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plas

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
​Oh, it was added because there was that weird Qt bug that used to flood the logs (pre 5.2) Any objections to me removing it? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
If that still works fine, why was this argument added? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread Bhushan Shah
On Fri, Jan 2, 2015 at 10:13 PM, David Edmundson wrote: > Won't these messages will get eaten by our noMessageOutput message handler > on login anyway? To workaround edit plasmashell.desktop to remove --shut-up Exec=plasmashell --shut-up to Exec=plasmashell -- Bhushan Shah http://bhush9.githu

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
Won't these messages will get eaten by our noMessageOutput message handler on login anyway? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread Aleix Pol
Git commit cd946735793ad837d5c71145c8cbe0faed158937 by Aleix Pol. Committed on 02/01/2015 at 15:41. Pushed by apol into branch 'master'. Check for errors when the GetConfigOperation returns Maybe there lies the answer to the indomitable startup black screen. CCMAIL: plasma-devel@kde.org M +3