Re: [patch] enabling autorun in devicenotifier applet

2011-01-06 Thread Aaron J. Seigo
On Wednesday, January 5, 2011, todd rme wrote: > Sorry if I missed this, but is this going to be a per-device setting, > per device-class setting, or both? I can see benefits for both. For yes, they are related but different. imho: for per device autorun, either put it on the device itself or b

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Kevin Ottens
On Thursday 6 January 2011 08:32:16 todd rme wrote: > Sorry if I missed this, but is this going to be a per-device setting, > per device-class setting, or both? I can see benefits for both. For > instance for a video DVD it probably doesn't matter which DVD it is. > On the other hand my camera me

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread todd rme
On Thu, Jan 6, 2011 at 2:08 AM, Kevin Ottens wrote: > On Wednesday 5 January 2011 19:19:55 Aaron J. Seigo wrote: >> On Wednesday, January 5, 2011, Kevin Ottens wrote: >> > But my point is that we also have this automounter service nowaday, so >> > the autorun logic could be moved there. >> >> yes,

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Kevin Ottens
On Wednesday 5 January 2011 19:19:55 Aaron J. Seigo wrote: > On Wednesday, January 5, 2011, Kevin Ottens wrote: > > But my point is that we also have this automounter service nowaday, so > > the autorun logic could be moved there. > > yes, that could make sense ... esp for services that need the v

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Aaron J. Seigo
On Wednesday, January 5, 2011, Jacopo De Simoi wrote: > I can help with moving the code to a more appropriate place (if help is > needed of course!) it would be great if you'd be up for doing that! :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Jacopo De Simoi
> On Wednesday, January 5, 2011, Jacopo De Simoi wrote: > > Was there a specific reason for patching the notifier? > > yep: Maarten, who wanted, the feature appear on irc and i offered a few > places > he could do this, and he picked the easiest and shortest path. the itch he > was > scratchin

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Aaron J. Seigo
On Wednesday, January 5, 2011, Aaron J. Seigo wrote: > started with as a basis.. fedora? mandriva / mageia :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc D

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Aaron J. Seigo
On Wednesday, January 5, 2011, Jacopo De Simoi wrote: > Was there a specific reason for patching the notifier? yep: Maarten, who wanted, the feature appear on irc and i offered a few places he could do this, and he picked the easiest and shortest path. the itch he was scratching is this: he's pu

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Jacopo De Simoi
> Hi, > > I've made this patch with some directions from aseigo. > > I wanted some kind of autorun settings for specific devices dependant on the > media of optical drives; so i made a patch to recognize X-KDE-Autorun in > .desktop file action entries. > > this patch was for 4.5.90 and it buil

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Aaron J. Seigo
On Wednesday, January 5, 2011, Kevin Ottens wrote: > But my point is that we also have this automounter service nowaday, so the > autorun logic could be moved there. yes, that could make sense ... esp for services that need the volume to be mounted first. > Of course would mean that automount >

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Kevin Ottens
On Wednesday 5 January 2011 09:06:58 Aaron J. Seigo wrote: > On Tuesday, January 4, 2011, Kevin Ottens wrote: > > Hm, why not resurrect the support for the Autorun XDG spec[*]? We used to > > have that but it's defunct for a while, IIRC there's some disabled code > > for it in the soliduiserver cod

Re: [patch] enabling autorun in devicenotifier applet

2011-01-05 Thread Aaron J. Seigo
On Tuesday, January 4, 2011, Kevin Ottens wrote: > Hm, why not resurrect the support for the Autorun XDG spec[*]? We used to > have that but it's defunct for a while, IIRC there's some disabled code > for it in the soliduiserver code. isn't that for once the medium is mounted? -- Aaron J. Seigo

Re: [patch] enabling autorun in devicenotifier applet

2011-01-04 Thread Ben Cooksley
On Wed, Jan 5, 2011 at 3:04 PM, Maarten Vanraes wrote: > Hi, > > I've made this patch with some directions from aseigo. > > I wanted some kind of autorun settings for specific devices dependant on the > media of optical drives; so i made a patch to recognize X-KDE-Autorun in > .desktop file action

Re: [patch] enabling autorun in devicenotifier applet

2011-01-04 Thread Kevin Ottens
On Wednesday 5 January 2011 03:04:41 Maarten Vanraes wrote: > I've made this patch with some directions from aseigo. > > I wanted some kind of autorun settings for specific devices dependant on > the media of optical drives; so i made a patch to recognize X-KDE-Autorun > in .desktop file action en

[patch] enabling autorun in devicenotifier applet

2011-01-04 Thread Maarten Vanraes
Hi, I've made this patch with some directions from aseigo. I wanted some kind of autorun settings for specific devices dependant on the media of optical drives; so i made a patch to recognize X-KDE-Autorun in .desktop file action entries. this patch was for 4.5.90 and it builds. couldn't test