Re: [patch] Fix network monitor colors and stacking

2010-05-22 Thread Petri Damstén
On Fri, May 21, 2010 at 10:27 PM, Aaron J. Seigo wrote: > On May 21, 2010, Petri Damstén wrote: >> On Fri, May 21, 2010 at 7:27 PM, Aaron J. Seigo wrote: >> > On May 18, 2010, Petri Damstén wrote: >> >> On Mon, May 17, 2010 at 1:52 PM, Sergey wrote: >> >> > Problem: >> >> >  It's very hard to un

Re: [patch] Fix network monitor colors and stacking

2010-05-21 Thread Aaron J. Seigo
On May 21, 2010, Petri Damstén wrote: > On Fri, May 21, 2010 at 7:27 PM, Aaron J. Seigo wrote: > > On May 18, 2010, Petri Damstén wrote: > >> On Mon, May 17, 2010 at 1:52 PM, Sergey wrote: > >> > Problem: > >> > It's very hard to understand on the network monitor plasmoid which > >> > line is d

Re: [patch] Fix network monitor colors and stacking

2010-05-21 Thread Petri Damstén
On Fri, May 21, 2010 at 7:27 PM, Aaron J. Seigo wrote: > On May 18, 2010, Petri Damstén wrote: >> On Mon, May 17, 2010 at 1:52 PM, Sergey wrote: >> > Problem: >> >  It's very hard to understand on the network monitor plasmoid which >> >  line is download and which is upload speed. They also stack

Re: [patch] Fix network monitor colors and stacking

2010-05-21 Thread Aaron J. Seigo
On May 18, 2010, Petri Damstén wrote: > On Mon, May 17, 2010 at 1:52 PM, Sergey wrote: > > Problem: > > It's very hard to understand on the network monitor plasmoid which > > line is download and which is upload speed. They also stack and > > this is not really usual for this kind of graphs. >

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
On May 18, 2010, Petri Damstén wrote: > It was stacked before but there were complains that it's hard to > read what is the value of the top graph, so it was changed to be not > stacked. But it's currently stacked without a patch, isn't it? -- Sergey

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
On May 17, 2010, Aaron J. Seigo wrote: Thanks for your comments. > * using hardcoded colors isn't going to work with all themes; this needs to > use the Plasma::Theme colors in the some way, even if it means expsing more > of > the colors in the color scheme to do so Well, without a patch

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
On May 18, 2010, Michel Lafon-Puyo wrote: > I think the plotters should use the Plasma::Theme colors by default but could > it be a configuration option too? From user's point of view if I looked for colors settings I would look in applet settings, not in a theme. > In fact, a lot of configur

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Michel Lafon-Puyo
Le mardi 18 mai 2010 09:26:47, Petri Damstén a écrit : > I have also made a complex plotter for those who want tweak everything > (http://kde-look.org/content/show.php/Complex+Plotter?content=111400). > I would like to keep default plotter as clean as possible, but I > really don't know anymore wha

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Petri Damstén
On Mon, May 17, 2010 at 1:52 PM, Sergey wrote: > Problem: >  It's very hard to understand on the network monitor plasmoid which >  line is download and which is upload speed. They also stack and >  this is not really usual for this kind of graphs. It was stacked before but there were complains th

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Petri Damstén
On Tue, May 18, 2010 at 9:45 AM, Michel Lafon-Puyo wrote: > Hi, > > I'm currently working on improvements for the system-monitor applet (see > http://reviewboard.kde.org/r/3950/) so I could help on this discussion. > > Le mardi 18 mai 2010 01:58:09, Aaron J. Seigo a écrit : >> * using hardcoded co

Re: [patch] Fix network monitor colors and stacking

2010-05-17 Thread Michel Lafon-Puyo
Hi, I'm currently working on improvements for the system-monitor applet (see http://reviewboard.kde.org/r/3950/) so I could help on this discussion. Le mardi 18 mai 2010 01:58:09, Aaron J. Seigo a écrit : > * using hardcoded colors isn't going to work with all themes; this needs > to use the Pl

Re: [patch] Fix network monitor colors and stacking

2010-05-17 Thread Aaron J. Seigo
hi Sergey ... On May 17, 2010, Sergey wrote: > Problem: > It's very hard to understand on the network monitor plasmoid which > line is download and which is upload speed. They also stack and > this is not really usual for this kind of graphs. thanks for the patch; i'll let the system monito

[patch] Fix network monitor colors and stacking

2010-05-17 Thread Sergey
As suggested in http://bugs.kde.org/show_bug.cgi?id=237922 I'm sending a patch here as well. Problem: It's very hard to understand on the network monitor plasmoid which line is download and which is upload speed. They also stack and this is not really usual for this kind of graphs. Solut