2009/1/22 Bruno Bigras :
> Comments would be appreciated, especially for the foreach patch.
* Qt::SizeHint is an enum, there is no need to use const references
with it (it shuold probably be ignored in krazy proper)
in 5_strings.diff I don't think that explicity wrapping literals in
QString is ne
On Thursday 22 January 2009, Bruno Bigras wrote:
> Comments would be appreciated, especially for the foreach patch.
everything except the strings patch can go in; wrapping everything in QString
just makes it less readable for no actual gain in these cases imo.
--
Aaron J. Seigo
humru othro a ko
2009/1/22 Bruno Bigras :
> Comments would be appreciated, especially for the foreach patch.
* Qt::SizeHint is an enum, there is no need to use const references
with it (it shuold probably be ignored in krazy proper)
in 5_strings.diff I don't think that explicity wrapping literals in
QString is ne
On Thursday 22 January 2009 04:49:59 Bruno Bigras wrote:
> Comments would be appreciated, especially for the foreach patch.
Well, I took a look at all patches and they look fine for me. Maybe I didn't
see something so it's best to wait for another opinion (/me sleeping today)...
But it looks nic
Comments would be appreciated, especially for the foreach patch.
apply in kdeplasma-addons/applets
Thanks!
Bruno
Index: lancelot/app/src/models/OpenDocuments.cpp
===
--- lancelot/app/src/models/OpenDocuments.cpp (révision 914945)
+
