Nicely done, a few minor comments still, but a "ship it!" from me.
Applet:
Missing Messages.sh file
This is needed to tell the translation mechanism to extract the
messages in the i18n functions
Copy this from another existing applet. Make sure you copy a version
from an applet that already u
>
> Is it ready to give it another review?
>
Yes it is, but please have a look at the nepomukcontroller-qml branch
in kde-workspace as this is the codebase I like to git merge in about
2 weeks if no one is against it.
The code base is the same as in my scratch repo, but the cmake part
is a bit di
Awesome,
Is it ready to give it another review?
David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
>
> Nicely done! I did a quick look over the code and you're still using
>
> QDBusConnection::sessionBus().interface()->isServiceRegistered
>
> which unfortunately is a blocking DBus call. You can however replace it with
> something like [...]
>
Thanks a lot for the hint. I've change my code to us
On Tue, Mar 26, 2013 at 11:29 AM, Jörg Ehrichs wrote:
> > [...]
> >
> > These things should really be async.
> >
> > Especially if there can be multiple services that you have no control
> about,
> > they will hang at some point, and then your UI is blocked -- never a good
> > thing.
> >
> > We'v
> [...]
>
> These things should really be async.
>
> Especially if there can be multiple services that you have no control about,
> they will hang at some point, and then your UI is blocked -- never a good
> thing.
>
> We've had a non-funny amount of UI problems due to sync calls across IPC, or
> i
On Wednesday, March 20, 2013 20:55:02 Jörg Ehrichs wrote:
> > IMHO all of these need to be replaced with the async variants. This
> > unfortunately affects a lot of your code. The service job should be
> > easy as you don't wait for the results, the service engine is less of
> > any easy change. Yo
On Wed, Mar 20, 2013 at 8:55 PM, Jörg Ehrichs wrote:
> > IMHO all of these need to be replaced with the async variants. This
> > unfortunately affects a lot of your code. The service job should be
> > easy as you don't wait for the results, the service engine is less of
> > any easy change. You m
>
> - Is there a reason nepomukserviceengine.cpp has a different license?
>
No this was simply an error, I'll fix it.
> - You are making a lot of synchronous dbus calls in the dataengine.
> Synchronous dbus calls block all of plasma-desktop until Nepomuk
> replies.
>
> IMHO all of these need to b
On Tue, Mar 19, 2013 at 6:34 PM, Jörg Ehrichs wrote:
> 2013/3/19 Ignacio Serantes :
>> Hi,
>>
>> Installed and is an amazing improvement. Only for contribute with minor
>> thing:
>>
>> A method to call a manual backup or a restore.
>> A start/stop/restart nepomuk method.
>>
>
> Start/Stop for any
2013/3/19 Ignacio Serantes :
> Hi,
>
> Installed and is an amazing improvement. Only for contribute with minor
> thing:
>
> A method to call a manual backup or a restore.
> A start/stop/restart nepomuk method.
>
Start/Stop for any service is available in the Plasma::DataEngine you can
check with t
11 matches
Mail list logo
