Re: [KDEREVIEW] DeviceNotifier refactor

2009-02-03 Thread Alessandro Diaferia
2009/2/3 Aaron J. Seigo > On Tuesday 03 February 2009, Alessandro Diaferia wrote: > > I've just moved my DeviceNotifier refactoring to kdereview. I feel it is > > much nicer but since i removed tons of code i'd like you to review it and > > tell me if something is wrong. > > some comments/thought

Re: [KDEREVIEW] DeviceNotifier refactor

2009-02-03 Thread Aaron J. Seigo
On Tuesday 03 February 2009, Alessandro Diaferia wrote: > I've just moved my DeviceNotifier refactoring to kdereview. I feel it is > much nicer but since i removed tons of code i'd like you to review it and > tell me if something is wrong. some comments/thoughts on the code (besides that Kevin alr

Re: [KDEREVIEW] DeviceNotifier refactor

2009-02-03 Thread Alessandro Diaferia
2009/2/3 Kevin Ottens > On Tuesday 3 February 2009 16:57:19 Alessandro Diaferia wrote: > > I've just moved my DeviceNotifier refactoring to kdereview. I feel it is > > much nicer but since i removed tons of code i'd like you to review it and > > tell me if something is wrong. > > Warning: I took

Re: [KDEREVIEW] DeviceNotifier refactor

2009-02-03 Thread Kevin Ottens
On Tuesday 3 February 2009 16:57:19 Alessandro Diaferia wrote: > I've just moved my DeviceNotifier refactoring to kdereview. I feel it is > much nicer but since i removed tons of code i'd like you to review it and > tell me if something is wrong. Warning: I took only a very quick glimpse at it (di

[KDEREVIEW] DeviceNotifier refactor

2009-02-03 Thread Alessandro Diaferia
Hi ML, I've just moved my DeviceNotifier refactoring to kdereview. I feel it is much nicer but since i removed tons of code i'd like you to review it and tell me if something is wrong. Since i called the plugin notifier-refactor you can have both the original one and the new one installed without o