D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50978. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50974&id=50978 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/short

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#405084 <https://phabricator.kde.org/D18717#405084>, @mvourlakos wrote: > it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues, > we are ok to commit if the property is moved to Layout

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50974. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50814&id=50974 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/short

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#404861 <https://phabricator.kde.org/D18717#404861>, @mvourlakos wrote: > @trmdi can you confirm me the following for your code ? > > 1. When a layout is loaded for first time then "global shortcuts based on position" are a

D18717: improvements for global shortcuts

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 403880 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717

D18620: Display shortcut badges while holding Super

trmdi added a comment. In D18620#404023 <https://phabricator.kde.org/D18620#404023>, @mvourlakos wrote: > @trmdi can you please test latest master for global shortcuts? No problem, I'm testing it, I'll give you feedback if I find anything. REPOSITORY R878 L

D18620: Display shortcut badges while holding Super

trmdi marked 2 inline comments as done. trmdi added a comment. In D18620#402845 <https://phabricator.kde.org/D18620#402845>, @mvourlakos wrote: > @trmdi this is ok, you can merge it and afterwards we can discuss how the Meta behavior should be enabled/disabled/adjusted... &

D18620: Display shortcut badges while holding Super

trmdi updated this revision to Diff 50574. trmdi marked an inline comment as done. trmdi retitled this revision from "Display shortcut badges while holding Super_L" to "Display shortcut badges while holding Super". trmdi edited the summary of this revision. REPOSITORY R878

D18620: Display shortcut badges while holding Super_L

trmdi updated this revision to Diff 50569. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18620?vs=50564&id=50569 REVISION DETAIL https://phabricator.kde.org/D18620 AFFECTED FILES CMakeLists.txt README.md app/CMakeLists.txt

D18620: Display shortcut badges while holding Super_L

trmdi added a comment. In D18620#402521 <https://phabricator.kde.org/D18620#402521>, @mvourlakos wrote: > @trmdi > > 1. does it work? any issues? > 2. under wayland did you have any success? 1. It works without any issue with my use case. Not sure ot

D18620: Display shortcut badges while holding Super_L

trmdi created this revision. trmdi added reviewers: Latte Dock, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Use `KModifierKeyInfo` to display shortcut badges while holding Super_L BUG: 401768

D18258: Wait forever until the lock file can be locked

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - `timeout = 3000` is a bit short on some computer. Use `timeout = -1` will work for any case

D17073: Do not crop albumArt

trmdi updated this revision to Diff 47876. trmdi edited the summary of this revision. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=46007&id=47876 REVISION DETAIL https://phabricator.kde

D17073: Do not crop albumArt

trmdi added a comment. How about this? I'd send a new patch if it's possible to change 2 things in one patch. F6486761: test.png <https://phabricator.kde.org/F6486761> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein,

D16890: [systemtray] Keep config entries after modifying

trmdi added a comment. In D16890#366015 <https://phabricator.kde.org/D16890#366015>, @anthonyfieroni wrote: > To commit it @mart @broulik ? I think that is not the root cause. You should fix the root cause instead of just a part of it. See my comment on https://bug

D17073: Do not crop albumArt

trmdi added a comment. In D17073#364393 <https://phabricator.kde.org/D17073#364393>, @ndavis wrote: > That blur looks nice, but I think the background should be more opaque like the Elisa header background.F6437066: Screenshot_20181122_005432.png <https://phabricator.kde.

D17073: Do not crop albumArt

trmdi updated this revision to Diff 46007. trmdi edited the test plan for this revision. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17073?vs=45950&id=46007 REVISION DETAIL https://phabricator.kde.org/D17073 AFFECTED FILES applets/taskman

D17073: Do not crop albumArt

trmdi added a comment. How about this ? F6436415: test.png <https://phabricator.kde.org/F6436415> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17073 To: trmdi, hein, broulik, ngraham, #vdg Cc: abetts, anthonyfieroni, plasma-devel, ragreen, Pitel, Z

D17073: Do not crop albumArt

trmdi created this revision. trmdi added reviewers: hein, broulik, ngraham, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Because: - the standard aspect ratio of `albumImage` is always `1:1` - we