D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-05 Thread Thorsten Bonhagen
thorstenb added a comment. What you are missing is the Gui part to store the pin in the network-manager config file. This is correct. I've not implementet a GUI yet. This is just the part for reading the config file values. REPOSITORY R116 Plasma Network Management Applet REVISION DETAI

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-04 Thread Thorsten Bonhagen
thorstenb updated this revision to Diff 20364. thorstenb edited the summary of this revision. thorstenb added a comment. fix for pin-value in middle of line REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8134?vs=20328&id=20364 BRAN

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-04 Thread Thorsten Bonhagen
thorstenb added a comment. The openconnect-plugin is not used for parsing this variable. Maybe it was in the past. I add my pin in "nm-servie-defines.h" near NM_OPENCONNECT_KEY_USERCERT. It was not used. I try to add this code in openconnect plugin in first place, but it was not working

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-10-03 Thread Thorsten Bonhagen
thorstenb marked 8 inline comments as done. thorstenb added a comment. Hi, i've done a arc redo because of "arc patch" not working and web "diff update" also not working. https://phabricator.kde.org/D8134 is the updated patch with the requested coding style. Sorry for not using arc in

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb edited the summary of this revision. thorstenb added reviewers: Plasma, jgrulich. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D8134 To: thorstenb, #plasma, jgrulich Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D8134: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb retitled this revision from "fix Coding style" to "plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value with updated coding style". thorstenb edited the summary of this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricato

D8134: fix Coding style

2017-10-03 Thread Thorsten Bonhagen
thorstenb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R116 Plasma Network Management Applet BRANCH arcpatch-D7795_1 REVISION DETAIL https://phabricator.kde.org/D8134 AFFECTED FILES vpn/opencon

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-19 Thread Thorsten Bonhagen
thorstenb added a comment. In have no idea about a sync from NM-openconnect plugin. Most code of NM-openconnect plugin is no longer in use. I my opinion it was for forking a openconnect command line process. Looks like most parts of NM-openconnect plugin are obsolete because of libopenconnec

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-13 Thread Thorsten Bonhagen
thorstenb added a reviewer: Plasma. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D7795 To: thorstenb, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7795: plasma-nm: vpn: openconnect: pkcs11: add support for separate pin value

2017-09-13 Thread Thorsten Bonhagen
thorstenb created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY openconnect: patch which add support for seperate pin value for pkcs11 url plasma-nm openconnect should support separate pin value in co

Re: Plasma-based presentation view for calligra-stage

2011-03-21 Thread Thorsten Zachmann
when using dbus stage needs to be running. It could also be started from the plasma frontend. The amound of data is not that big so that it would be a problem to transfer the data via dbus. If used plasma internally it should be made sure that this is an optional dependency that is not needed if the

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-29 Thread thorsten
> > >> On 2009-09-29 05:32:23, Thorsten Staerk wrote: >> > I committed the change, see >> http://websvn.kde.org/?view=revision&revision=1029142. Where can I set >> this to completed? > > there is somewhere a button here that lets you set this to submit

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
=revision&revision=1029142. Where can I set this to completed? - Thorsten On 2009-09-19 20:16:41, Davide Bettio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboar

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-28 Thread Thorsten Staerk
} -this->setToolTip( qTip ); +this->setToolTip( "ktimetracker", "ktimetracker", qTip ); } #include "tray.moc" - Thorsten On 2009-09-19 20:16:41, Davide Bettio wrote: > > -

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can fin

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-24 Thread Thorsten Staerk
> On 2009-09-21 13:41:29, Thorsten Staerk wrote: > > Good to see you working on my baby ktimetracker. Let's have a discussion on > > irc. > > Davide Bettio wrote: > ok. my timezone is CET. I'm on IRC in the afternoon and in the night. You > can fin

Re: Review Request: Ported KTimeTracker to KNotification

2009-09-21 Thread Thorsten Staerk
ave a discussion on irc. - Thorsten On 2009-09-19 20:16:41, Davide Bettio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboa