D16365: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread mat gr
grmat added a comment. Thanks for the comments, review and for splitting up the diff. I also know it was daunting to review the patch in its original form and I could've done that better. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D16365 To: ohelin, jackg

D15786: share common values for both Breeze and Breeze-dark GTK themes

2018-10-25 Thread mat gr
grmat added a comment. Thanks for the review, comments and for splitting up the diff. I also know it was daunting to review the patch in its original form and I could've done that better. I'll see if I can test the updated version in the upcoming days. REPOSITORY R98 Breeze for Gtk REVI

D14068: add -P switch to one-shot redshift call

2018-09-27 Thread mat gr
grmat added a comment. In D14068#332672 , @davidedmundson wrote: > what happens to users on older versions? It breaks, as redshift <1.12 will exit with "invalid option -- 'P'". I initially just thought of this as packaging responsibi

D15786: share common values for both Breeze and Breeze-dark GTK themes

2018-09-26 Thread mat gr
grmat added a comment. additional note: commit 1ea1e0f88d0812d0f7b8e542bd9eacee234a93ee is also strongly related to this change as it introduced lots of additional colour variables. For this change, the dark scheme wa

D15786: share common values for both Breeze and Breeze-dark GTK themes

2018-09-26 Thread mat gr
grmat created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. grmat requested review of this revision. REVISION SUMMARY As described in bug #396091, the Breeze-dark theme is often neglected in updates. This patch fixes #396091 and some additional, related

D14068: add -P switch to one-shot redshift call

2018-07-12 Thread mat gr
grmat added a comment. I was hoping the bug would get linked in automatically... anyways, here it is, with additional information: https://bugs.kde.org/show_bug.cgi?id=395641 REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: grmat Cc: pla

D14068: add -P switch to one-shot redshift call

2018-07-12 Thread mat gr
grmat created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. grmat requested review of this revision. REVISION SUMMARY This trivial patch adds the missing parameter to get the familiar behaviour working for redshift versio