Re: Review Request: PATCH: Configuration Dialog for Turning off Notifications in the Panel

2009-01-17 Thread guitarist198
> On 2009-01-17 10:17:37, Aaron Seigo wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp, line > > 413 > > > > > > missing space: } else I have added the parents to both checkboxes and ad

Re: Review Request: PATCH: Configuration Dialog for Turning off Notifications in the Panel

2009-01-17 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/331/ --- (Updated 2009-01-17 11:14:51.322646) Review request for Plasma. Summary -

Re: Review Request: PATCH: Configuration Dialog for Turning off Notifications in the Panel

2009-01-17 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/331/ --- (Updated 2009-01-17 09:53:04.137350) Review request for Plasma. Summary -

Review Request: PATCH: Configuration Dialog for Turning off Notifications in the Panel

2009-01-16 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/331/ --- Review request for Plasma. Summary --- This patch allows one to turn o

Re: Review Request: Override showOnlyCurrentDesktop for demandsAttention

2008-08-18 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/131/ --- (Updated 2008-08-18 18:33:42.206447) Review request for Plasma. Summary -

Re: Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-18 Thread guitarist198
> On 2008-08-13 07:04:36, Alex Merry wrote: > > /trunk/KDE/kdebase/workspace/libs/taskmanager/taskrmbmenu.cpp, line 264 > > > > > > There should be an & before the word "Desktop", as in the > > makeDesktopsMenu(TaskPtr)

Re: Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-18 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/133/ --- (Updated 2008-08-18 18:13:34.778758) Review request for Plasma. Summary -

Re: Review Request: Implementation of manual group for tasks applet.

2008-08-16 Thread guitarist198
> On 2008-08-16 20:45:06, Aaron Seigo wrote: > > How does this meet up with Christian Mollekopf's work on grouping/sorting > > in libtaskmanager? If it is a completely separate implementation, then this > > will have to wait until that is done as Christian has already put a fair > > amount of

Re: Review Request: Implementation of manual group for tasks applet.

2008-08-16 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/136/ --- (Updated 2008-08-16 18:57:20.523427) Review request for Plasma. Summary -

Review Request: Implementation of manual group for tasks applet.

2008-08-16 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/136/ --- Review request for Plasma. Summary --- This is an implementation of ma

Re: Review Request: Override showOnlyCurrentDesktop for demandsAttention

2008-08-13 Thread guitarist198
> On 2008-08-13 07:19:52, Alex Merry wrote: > > What happens when you click on a task that wants attention from another > > desktop? Is the task brought to your current desktop, or does the desktop > > change to the one where the task is? > > > > Also, it would be better if you didn't delete

Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-12 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/133/ --- Review request for Plasma. Summary --- If one uses the taskrmbmenu wit

Review Request: Add missing "All to Desktop" submenu title to taskrmbmenu makeDesktopsMenu() function.

2008-08-12 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/133/ --- Review request for Plasma. Summary --- If one uses the taskrmbmenu wit

Re: Review Request: Override showOnlyCurrentDesktop for demandsAttention

2008-08-10 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/131/ --- (Updated 2008-08-10 10:09:39.700476) Review request for Plasma. Summary -

Review Request: Override showOnlyCurrentDesktop for demandsAttention

2008-08-10 Thread guitarist198
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/131/ --- Review request for Plasma. Summary --- This patch applies to the tasks