Re: Move Breeze to Framework

2024-12-30 Thread christoph
am confused with that. Would kcolorscheme then depend on breeze? Without it, it would be again back to more or less useless as it ships no proper color scheme nor will the dark mode switching work. Same for kiconthemes, that relies on that to work with just kcolorscheme & breeze-icons. Greetings Christoph Nate

Re: Move Breeze to Framework

2024-12-30 Thread christoph
SDDM theme, Plasma SVG theme) into that repo as well. But that can be a longer term thing. Nate Greetings Christoph

Re: Move Breeze to Framework

2024-12-17 Thread christoph
ycle which I think I not nice as Kate will wait for Plasma releases to get fixes. Beside that the development story is in my eyes not good if apps need to require Plasma parts, it is in my eyes a lot nicer to have this on the Framework level, like the Breeze icons are already. Greetings Christoph David

Re: Move Breeze to Framework

2024-12-17 Thread christoph
part there and having it in sync with Frameworks releases is nice for apps, too. Greetings Christoph Cheers, Carl

[ksysguard] [Bug 390671] Add "Kill X Server" including Keyboard shortcut to Tools menu

2024-09-23 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390671 Christoph Cullmann changed: What|Removed |Added Resolution|--- |UNMAINTAINED Status|REPORTED

[ksysguard] [Bug 395095] Add a process details dialog showing more information from /proc/[pid]/stat

2024-09-23 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=395095 Christoph Cullmann changed: What|Removed |Added Resolution|--- |UNMAINTAINED Status|REPORTED

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-11 Thread christoph
est with just one variant. And one would always use the variant Windows uses. Hi, any more feedback about this? Greetings Christoph Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
s use the variant Windows uses. Greetings Christoph Nate

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
, if we are atm moving stuff, might it make sense to move Baloo, too, given it only is usable with the daemon inside Plasma more or less, too? Greetings Christoph Baloo is linked by some apps, e.g. Elisa, and I wouldn't like to make them haul in Plasma stuff. Hi, some applications li

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread christoph
usable with the daemon inside Plasma more or less, too? Greetings Christoph Without any de-KF-ication though this will break things though for building consumers soonish. Example --- 8< --- find_package(KF6 ${KF_MIN_VERSION} REQUIRED COMPONENTS CoreAddons Plasma ) --

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-10 Thread christoph
ne", "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "master"} Would it be something like: {"trunk": "master", "stable": "none", "stable_kf5": "release/23.08", "trunk_kf5": "none"} Greetings Christoph

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-09 Thread christoph
eek to chime in. Let's make our Qt 6 based 'bundled' release next year a good one ;) Greetings Christoph Cheers, Albert Greetings Christoph >> - The KDE Gear release will move by 2 months to allow for the extra >> >> time needed for testing initial Qt6

Re: Frameworks / Plasma/ Gear Release Schedule Plan

2023-09-09 Thread christoph
https://invent.kde.org/utilities/kate/-/blob/master/.gitlab-ci.yml?ref_type=heads and require KF 6 + Qt 6 in the CMake files or is there additional stuff that needs updates to avoids one breaks stuff? Greetings Christoph - The KDE Gear release will move by 2 months to allow for the extra time n

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2021-08-15 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 --- Comment #14 from Christoph Feck --- Qt developers say it is fixed in Qt 6. -- You are receiving this mail because: You are the assignee for the bug.

Re: Alternate calendar in plasma - feature request discussion

2020-12-08 Thread Christoph Feck
ystem-enum This class is new as of Qt 5.14, so we couldn't depend on it yet. If the Chinese calendar support needs to be added in Qt, I suggest to contact developers at the Qt development mailing list. BG, Christoph

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2020-12-04 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||krzmb...@gmail.com --- Comment #12 from

Re: Plasma and a bachelor thesis

2020-10-21 Thread Christoph Feck
could also use these for inspirations: - Brainstorm in KDE Forums: https://forum.kde.org/viewforum.php?f=83 - https://itvision.altervista.org/why.linux.is.not.ready.for.the.desktop.current.html On a more personal note, see https://bugs.kde.org/show_bug.cgi?id=252353 BG, Christoph

[ksysguard] [Bug 424128] libksysguard "make install" fails with ./kdesrc-build

2020-08-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=424128 Christoph Feck changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2020-07-21 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||oceanodefol...@pm.me --- Comment #8 from

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck
cfeck added a comment. Instead of darker, you could use the text color with very small alpha. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The

D29081: [QStyle] Make menu titles look less like menu items

2020-05-06 Thread Christoph Feck
cfeck added a comment. What a small difference that makes such a large difference! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081 To: ngraham, #vdg, #breeze, niccolove, ndavis Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-D

D28941: startplasma: Sort environment scripts prior to sourcing

2020-04-27 Thread Christoph Feck
cfeck added a comment. It looks like the submitter doesn't have commit rights. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28941 To: auxym, #plasma, davidedmundson, apol Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zach

D25428: Improved support for desktop "Folder View"

2020-03-19 Thread Christoph Feck
cfeck added a comment. Anyone else able to review this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-10 Thread Christoph Feck
cfeck added a comment. See https://bugreports.qt.io/browse/QTBUG-56547 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

2020-03-10 Thread Christoph Feck
cfeck added a comment. We already lost fractional point sizes when porting from KFontDialog to QFontDialog. Best approach is to add the KFontDialog to the platform plugin (and also the old KColorDialog while you are at it), or upstream our features to Qt. Btw, I set Toolbar font to a "c

D27650: ItemContainer: disconnect signals in destructor

2020-03-06 Thread Christoph Feck
cfeck added a comment. If this is still needed, please commit and clarify the status of the referenced bug. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To: alnikiforov, ngraham, davidedmundson, mart Cc: cfeck, anthonyfieroni, plasma-devel, Orage,

Re: breeze-gtk now in invent

2020-02-25 Thread Christoph Feck
release scrips and others will get a surprise when they want to make contributions to it. We have https://phabricator.kde.org/T11994 to track those moves, please subscribe there. -- Christoph Feck KDE Release Team

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-16 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R114:2c832dbdd087: Fix duplicate results for sessions, simplify and optimize (authored by alex, committed by cullmann). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D27380: [GTK Config] Write Font without style name

2020-02-13 Thread Christoph Feck
cfeck added a comment. So... is this all related to bug https://bugs.kde.org/show_bug.cgi?id=378523 ? :/ REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari, #plasma, ervin, bport, meven Cc: cfeck, ngraham, IlyaBizyaev, plasma-devel,

D27383: fix: reset doctor output color before exiting

2020-02-13 Thread Christoph Feck
cfeck added a comment. Since this patch isn't critical, it would make a perfect candidate for your first steps with committing :) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-deve

D27383: fix: reset doctor output color before exiting

2020-02-13 Thread Christoph Feck
cfeck added a comment. Oh, okey. That was just misleading. I also suggest to ask for commit rights then. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma-devel, Orage, LeGast00n,

D27383: fix: reset doctor output color before exiting

2020-02-13 Thread Christoph Feck
cfeck added a comment. According to https://phabricator.kde.org/R982:8dffcc64d2aec4041129d67809839f136fec080a you have commit rights? REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, romangg, plasma

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

2020-02-13 Thread Christoph Feck
cfeck added a comment. That looks clever. Since CpuInfoBufSize is a static variable, it will remember the last used size and not reallocate again (unless you plug in new CPUs). Is realloc() an option? It should help the case where the library can actually grow the buffer without an allo

D27362: Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs

2020-02-13 Thread Christoph Feck
cfeck added a comment. From that bug report: Newer x86_64 kernels, however, allow up to 4096 CPUs, so either the buffer needs to be much bigger, or we should do interleaved /proc/cpuinfo reading and parsing. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D273

Re: 2 kirigami fixes for a point release

2020-02-13 Thread Christoph Feck
On 02/13/20 08:42, Ben Cooksley wrote: Part of the issue here is that Plasma has been known to add API to Frameworks and then immediately, without any delay, start using it (pretty much always breaking CI in the process) This means that other changes are likely being pushed into Frameworks by Pl

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-09 Thread Christoph Cullmann
cullmann added a comment. Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=) REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://pha

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-09 Thread Christoph Cullmann
cullmann added a comment. Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27109 To: alex, b

D27109: Fix duplicate results for sessions, simplify and optimize

2020-02-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Improved output seems fine for me, thanks for taking care. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricato

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment. But the timeout isn't used to give apps more time needed to clean up before they confirm the session can be closed? If I understand it correctly, there should be two timeouts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To:

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Christoph Feck
cfeck added a comment. Why is there a timeout at all? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27077 To: ngraham, #vdg, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-01-21 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > standard_actions_module.cpp:73 > +m_editor->setMinimumWidth(700); > +m_editor->setMinimumHeight(600); > + `setMinimumSize()` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cf

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-01-21 Thread Christoph Feck
cfeck added a comment. Note that a window's minimum size does not include decorations or the panel. I suggest to subtract 60 pixels from the minimum height, otherwise on a 800x600 screen the buttons are likely hidden behind the panel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D24706: [RFC] Change button style

2020-01-17 Thread Christoph Feck
cfeck added a comment. If application developers need a rotated button, they need to rotate only the contents, not the frame. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plas

D26271: [Applet]Update layout based on T10470

2020-01-13 Thread Christoph Feck
cfeck added a comment. The radio stream I use (via mpv) shows the interpret and title information for all titles it plays. Also, when mpv plays a local file, ttitle information about the file is added there. I don't use any other media streams, so I cannot comment on the general availability

[Breeze] [Bug 369158] Breeze sddm theme broken on dual monitor setup (no cursor)

2019-12-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=369158 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

[Breeze] [Bug 375909] Breeze SDDM wallpaper was reset in KDE Neon 5.9 update

2019-12-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=375909 Christoph Feck changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

D25280: [Baloo KCM] Purge index when disabling indexing

2019-11-12 Thread Christoph Feck
cfeck added a comment. Shouldn't there be a warning message "delete yes/no?" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, davidedmundson Cc: cfeck, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24373: [KCM] Limit scale factor increment to 6.25% on X11

2019-10-20 Thread Christoph Cullmann
cullmann added a comment. On Wayland one seems to always scale up to the next full factor (e.g. 2) and then scale down the rendered stuff via gl to the selected factor (e.g 1.5). That leads to other issues but doesn't let rounding stuff creep into the rendering via Qt. For non IEEE

D24283: Add clang format file

2019-10-14 Thread Christoph Cullmann
cullmann added a comment. There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff. I don't think without the aligning the change will be much smaller. REPOSITORY R120 Plasma Workspace REVISION DE

D24283: Add clang format file

2019-10-12 Thread Christoph Cullmann
cullmann added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > s/coding/coding style/ Fixed that in D24568 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann, pl

D24283: Add clang format file

2019-10-11 Thread Christoph Cullmann
cullmann added a comment. This is just a base file for discussion. Stuff like the mentioned case indentation can be adjusted to be frameworks conform. For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don

D24283: Add clang format file

2019-10-11 Thread Christoph Cullmann
cullmann added a comment. See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style. Is the same file as here, with sorting of includes, but with column limit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D21860: Set a font for gtk applications in the fonts kcm

2019-10-11 Thread Christoph Feck
cfeck added a comment. Please make any GTK stuff optional, not required. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: cfeck, davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeG

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. I would just reformulate "Scale factors are limited to multiples of 6.25% on X11 to minimize visual glitches in applications." to "Scale factors are limited to multiples of 6.25% to minimize visual glitches in applications." I think adding X11 onl

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. Ok ,works for me, too. Sorry for the noise! And thanks for the explanation! I think this is already much better than before, the details of the last finesse with the minimal step can be discussed elsewhere. REPOSITORY R104 KScreen REVISION DETAIL https://phabr

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. Ok, that explains why all my tries fail... I thought the hint above about looking for kcm_screen in the system was just if I have mixed up some stuff, but I always thought if the QT_PLUGIN_PATH is properly set like with prefix.sh the local plugins will be prefered.

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. Ok, but given I have a system wide installed kcm anyways, from the distro, is there a way to use the own I have in my user local prefix? That explains why I am too dumb to try the fractional scaling on Wayland with my installed master version, too. REPOSITORY R1

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. Or I am maximal confused ;=) If I compile a master kscreen, have sourced the prefix.sh, shall I see the correct stuff in e.g. the kcm_testapp in bin of the kscreen build dir? If not, I am sorry, could somebody help me out how to test this properly? REPOSITO

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Besides, I think you missed half of the code, as for me, I still get a different widget here, as for my setup the OutputPanel.qml is used, not Panel.qml. (as I have two displays th

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. I don't get why we want to introduce artifacts we can very simple avoid by using a different base for the steps. Is 0.0625 really that much worse than 0.05? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. To illustrate that, just try, with master of KTextEditor: export QT_SCALE_FACTOR=1.125 kwrite with some file => select 100 lines, zoom font in and out => I get no artifacts export QT_SCALE_FACTOR=1.0625 > same == export QT_SCALE_FACTOR=1

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. Hmm, could we perhaps adjust the minimal step to 0,0625. That is 1/16 and with that, I never get any artifacts with KWrite in current master, as it nicely sums up. Then you don't need to round at all for output. REPOSITORY R104 KScreen REVISION DETAIL https:

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

2019-10-02 Thread Christoph Cullmann
cullmann added a comment. I like that UI, too. For Wayland: Can somebody tell me how I can try there some fractional scaling? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: dhaumann, davidedmundson, ouwerkerk,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. Even with my hacks for https://bugreports.qt.io/browse/QTBUG-66036 in current KTextEditor master (see https://bugs.kde.org/show_bug.cgi?id=390451) you will still get after every xx lines some stray artifact in some cases during selection if you have some 1.1 scaling

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. Ok, I wasted one evening on the rendering artifacts stuff. https://bugreports.qt.io/browse/QTBUG-66036 I have now ugly workarounds in KTextEditor: 1. no anti-aliasing, else fillRect misses to fill 1 pixel at the borders by rounding errors 2. adjust th

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. I got some more insight into https://bugreports.qt.io/browse/QTBUG-66036 If one turns off anti-aliasing, in KTextEditor most of the evil artifacts disappear, but not all. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. I will investigate the https://bugreports.qt.io/browse/QTBUG-66036 bug again, too :/ Even with the rounding issues one gets over larger multiplications, it shouldn't be that buggy for short ones. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. Ok, tried Wayland now on my HiDPI setup. In Plasma's KCM I only have Scale 1x or 2x and that works ok, as one would think. But I see no way to set any more fine-grained scale to check if the scaling is nice for other values. The slider is for me only there for

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. In D24321#540437 , @romangg wrote: > In D24321#540433 , @cullmann wrote: > > > ;=) I talked only about the Qt HiDPI scaling code paths. > > > In this case I recommend

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. Hmm, I just tried here a Wayland session, and yes, the KCM has there just some 1x/2x combobox and my fonts are maximal ugly compared to some export QT_SCALE_FACTOR=2 + starting a Qt application (on Wayland). But I must try that at home on real HiDPI screens, perhap

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. ;=) I talked only about the Qt HiDPI scaling code paths. For any other scaling I don't care, as that should be application transparent, like you say. But if Wayland really just scales up the stuff via GL fonts will look terrible. And no, its non-trivial t

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-10-01 Thread Christoph Cullmann
cullmann added a comment. In D24321#540218 , @davidedmundson wrote: > > For small 0.1 changes: Just change your font size, we did that always for the old non-hidpi world were displays did differ a bit in the DPI, that works without any glitch

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. In D24321#540056 , @davidedmundson wrote: > > it would go into Plasma 5.17. :) > > There's still a feature freeze. At least moving away from 0.1 increases is actually a bugfix. Look at my konsole screenshot,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. Hi, I thought about this a bit more ;) I really think we shall limit the minimal increase to 0.25, without any advanced field. Perhaps the range should be larger, like 1-4, if some people get "really" high DPI screens. Rational: 1. For small 0.1 change

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. Btw., I think GNOME is more clever than us, too, they allow just sane scalings in the UI: https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vd

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. And the custom scale factor dialog really should have some warning text like on Windows ;=) see e.g. https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html (custom scale factor not re

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. In D24321#540014 , @ngraham wrote: > In D24321#540011 , @cullmann wrote: > > > 0.05 is no good idea either ;) > > Just like 0.1 that is no 1/2, 1/4, 1/8, ... > > If we

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

2019-09-30 Thread Christoph Cullmann
cullmann added a comment. 0.05 is no good idea either ;) Just like 0.1 that is no 1/2, 1/4, 1/8, ... If we really need something finer than 0.25, could we stick with 1/8 or 1/16? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, ro

Re: New Plasma Desktop website

2019-09-14 Thread Christoph Feck
On 09/14/19 14:38, Carl Schwan wrote: I finalized the first version of the new plasma-desktop webpage, a preview is available at https://kde.carlschwan.eu/plasma-desktop. There are still two parts missing (p-b-i and privacy) and some possible improvement that I would like to add later. Can I g

Re: Plasma 5.12.9 LTS

2019-09-11 Thread Christoph Feck
in case of compilation errors. -- Christoph Feck KDE Release Team

D23803: [Folder View] Add subtle shadows to icons

2019-09-09 Thread Christoph Feck
cfeck added a comment. Isn't Qt Quick amazing? REPOSITORY R119 Plasma Desktop BRANCH add-subtle-icon-shadow-to-folderview (branched from master) REVISION DETAIL https://phabricator.kde.org/D23803 To: ngraham, hein, #plasma, #vdg, filipf, ndavis Cc: cfeck, ndavis, filipf, plasma-devel,

D23732: [kded] Support fractional output scale

2019-09-05 Thread Christoph Feck
cfeck added a comment. I believe 1.25 is a common scale factor. Is something else in the stack limited to one digit? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23732 To: romangg, #plasma Cc: cfeck, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D22740: Consistent virtual desktop numbering between Switch Window popup and taskbar

2019-08-15 Thread Christoph Feck
cfeck added a comment. Could someone test this on Wayland? The fix itself looks trivial, but if it breaks Wayland session, it obviously needs to be changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22740 To: marten, #plasma Cc: cfeck, plasma-devel, L

D18920: Fix PCI module

2019-08-01 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R102:8056039c7947: Fix PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18920?vs=61562&id=62955 REVISION DETAIL

D22369: Update and add some device names in PCI module

2019-08-01 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R102:ed789f56fc69: Update and add some device names in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22369?vs=

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2019-07-26 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 Christoph Feck changed: What|Removed |Added CC||marklikesvideogames@gmail.c

D22728: Provide a link to KInfoCenter

2019-07-25 Thread Christoph Feck
cfeck added a comment. +1 for putting it in the Help menu. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22728 To: ngraham, #plasma, #vdg Cc: cfeck, mthw, mmustac, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, him

D22630: Slow down the busy indicator's rotation speed

2019-07-21 Thread Christoph Feck
cfeck added a comment. Do we need a matching commit in KWidgetsAddons? See https://commits.kde.org/kwidgetsaddons/2631be903f947872f67c9e2063950345dda9033e REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cul

D22630: Slow down the busy indicator's rotation speed

2019-07-21 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. Jup, looks less iritating. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: filipf, plasma-devel, cullma

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

2019-07-20 Thread Christoph Cullmann
cullmann added a comment. Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

2019-07-18 Thread Christoph Feck
cfeck added a comment. Oh, if the latter syntax also works, then you are right. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesj

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

2019-07-18 Thread Christoph Feck
cfeck added a comment. Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd C

D22368: Formatting cleanup in PCI module

2019-07-10 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R102:196d4aaa9cf6: Formatting cleanup in PCI module (authored by konradr, committed by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22368?vs=61497&id=61533

D18920: Fix PCI module

2019-07-10 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kpci_private.h:48 > > +/* Following structurs MUST BE packed, otherwise variables will be mapped to > + wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are structure or structures? > kpci_private.h:49 > +/* Following struc

D22367: Update mail address in PCI module

2019-07-10 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R102:96c18ee3cf63: Update Konrad's mail address in PCI module (authored by cfeck). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22367?vs=61496&id=61531 REVISION D

D18245: Create QApplication in a scope to work around possible deadlock

2019-07-09 Thread Christoph Roick
croick abandoned this revision. croick added a comment. I can no longer reproduce the deadlock, so I'll abandon this. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18245 To: croick, sitter, #kdevelop Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, jraleigh, fbam

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-07-09 Thread Christoph Roick
croick added a comment. Thanks for your review. It was the last in a series of patches and I'll try to advertise the whole "Debug your KDE application with KDevelop"-feature somewhere. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick, #plasma_worksp

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-07-09 Thread Christoph Roick
This revision was automatically updated to reflect the committed changes. Closed by commit R871:95b6b8b613c2: Show debug button when KDevelop session is running (authored by croick). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=61377&id=61456 REVIS

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-07-08 Thread Christoph Roick
croick marked 2 inline comments as done. croick added a comment. In D11234#492200 , @sitter wrote: > Could you explain your thinking behind the adjustSize call please? The way I see it the window should scale up as necessary if the size hints are

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-07-08 Thread Christoph Roick
croick updated this revision to Diff 61377. croick added a comment. - more style fixes - do not adjustSize after adding the button, since that is redundant now REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=59627&id=61377 BRANCH nicebutton RE

  1   2   3   4   5   6   7   >