D28113: Fix initial loading of autostart program names

2020-04-11 Thread Yichao Yu
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c20db943b994: Fix initial loading of autostart program names (authored by yuyichao). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28113?vs=77876&id=79841

D28113: Fix initial loading of autostart program names

2020-03-30 Thread Yichao Yu
yuyichao added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28113 To: yuyichao, apol, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, l

D28113: Fix initial loading of autostart program names

2020-03-17 Thread Yichao Yu
yuyichao created this revision. yuyichao added reviewers: apol, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yuyichao requested review of this revision. REVISION SUMMARY When the auto start entry is first loaded, the module only take into account the

D7640: QtCurve: reduce progressbar timer overhead

2017-09-02 Thread Yichao Yu
yuyichao added a comment. > But I don't see how could do either for startTimer()? `const_cast(this)->startTimer()` REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D7640 To: rjvbb, yuyichao, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7640: QtCurve: reduce progressbar timer overhead

2017-09-01 Thread Yichao Yu
yuyichao accepted this revision. This revision is now accepted and ready to land. REPOSITORY R626 QtCurve REVISION DETAIL https://phabricator.kde.org/D7640 To: rjvbb, yuyichao, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D7640: QtCurve: reduce progressbar timer overhead

2017-09-01 Thread Yichao Yu
yuyichao added a comment. > Style::drawControl() is const, so one also has to move m_timer, m_progressBarAnimateTimer and m_progressBarAnimateFps to a private class, which in addition would have to have a q pointer and a startParentTimer() "proxy" so we can call Style::startTimer() from a co

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread Yichao Yu
--- Compiled, pager and icontasks shows minimized windows correctly. Also tested on openbox (+plasma's pager) by "Xuetian Weng". Thanks, Yichao Yu

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread Yichao Yu
applets/lancelot/application/LancelotWindow.cpp c66c565 Diff: https://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
> On 六月 4, 2016, 4:02 p.m., Yichao Yu wrote: > > LGTM, this should be added to the configure UI. The tab for popup menu > > should work. The .ui file needs to be updated to include the checkbox for > > this and a corresponding rule should be added to the .cpp file (There

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
popup menu should work. The .ui file needs to be updated to include the checkbox for this and a corresponding rule should be added to the .cpp file (There should already be a number of boolean options in that tab that you can copy.) - Yichao Yu On 六月 4, 2016, 3:53 p.m., René J.V. Bertin wrote

Re: Review Request 128097: optional mode to draw checked menu items with only a check mark

2016-06-04 Thread Yichao Yu
tps://git.reviewboard.kde.org/r/128097/#comment65011> Hm? Shouldn't this use the option? - Yichao Yu On 六月 4, 2016, 10:41 a.m., René J.V. Bertin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
s the best solution copying the plasma shadow code to here again? - Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 ------- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote:

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
- Yichao --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114424/#review45626 --- On Dec. 13, 2013, 7:53 a.m., Yichao Yu wrote

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-13 Thread Yichao Yu
indow.cpp c66c565 Diff: http://git.reviewboard.kde.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2013-12-12 Thread Yichao Yu
e.org/r/114424/diff/ Testing --- Compiles. Have shadow with both oxygen and qtcurve. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-05 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
> > The anongit network has now been checked over. One mirror as it turns out > was not updating correctly, which has now been repaired. > Please retry - it should now succeed. Yep it works now. Although I have already got what I want from quickgit. Cheers, Yichao Yu > >> &

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > May I ask if how did you get the rounded corner? I have got this[1] kind of white frame for menu with rounded corder and haven't found a good way to get rid of it (without interfering with other things) yet. [1] http://wstaw.org/m/2013/

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
On Tue, Dec 3, 2013 at 10:06 AM, Yichao Yu wrote: > On Tue, Dec 3, 2013 at 3:06 AM, Martin Klapetek > wrote: >> On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: >>> >>> On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler wrote: >>> > On Monday, Decemb

Re: Oxygen in QtQuickControls

2013-12-03 Thread Yichao Yu
On Tue, Dec 3, 2013 at 3:06 AM, Martin Klapetek wrote: > On Tue, Dec 3, 2013 at 5:18 AM, Yichao Yu wrote: >> >> On Mon, Dec 2, 2013 at 10:55 AM, Sebastian Kügler wrote: >> > On Monday, December 02, 2013 15:30:26 David Edmundson wrote: >> >> I'm working

Re: Oxygen in QtQuickControls

2013-12-02 Thread Yichao Yu
out or have any questions. Thanks for pointing this out. I would like to test all these but do you know if there are any "complete" example of QtQuick applications that I can play with (sth like oxygen-demo). P.S. I will be mostly working on improving QtQuick support in QtCurve and I h

Review Request 110015: Apply settings when clicking Apply button; do not overwrite history when applying settings.

2013-04-14 Thread Yichao Yu
://git.reviewboard.kde.org/r/110015/diff/ Testing (updated) --- Compiled and installed. The settings are saved correctly and the history is not lost. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 109164: set disable black listed applications

2013-02-25 Thread Yichao Yu
: http://git.reviewboard.kde.org/r/109164/diff/ Testing --- Compiled and run. blacklist widget is correctly disabled. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 109164: set disable black listed applications

2013-02-25 Thread Yichao Yu
/109164/diff/ Testing --- Compiled and run. blacklist widget is correctly disabled. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2013-01-16 Thread Yichao Yu
o tested on openbox (+plasma's pager) by "Xuetian Weng". Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: show notification summary for last popup notification

2012-12-16 Thread Yichao Yu
> On Dec. 16, 2012, 9:23 p.m., Aleix Pol Gonzalez wrote: > > I've been missing that too, especially with KTP notifications, since the > > sender is in there. > > I have no idea if it's the same case for other programs, though.. Well, same case for pidgin's login/out notification, in which the b

Review Request: Set history size before reading history so that all history can be loaded

2012-11-27 Thread Yichao Yu
/107499/diff/ Testing --- Compiled and installed. Set history size to > 3 and upload > 3 images/text files. Restart plasma and the history list is of the correct size. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: Convert file content to local encoding before uploading text file in the "share" dataengine

2012-10-25 Thread Yichao Yu
Diff: http://git.reviewboard.kde.org/r/107044/diff/ Testing --- Compiled, installed, upload a file with utf8 characters and the encoding is correct. Thanks, Yichao Yu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org