D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f9d31febf87e: Update the visiblity check for ActionToolbar by checking width with less… (authored by xuetianweng). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D29022: Update the check for ActionToolbar by checking with less-"equal".

xuetianweng created this revision. xuetianweng added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. xuetianweng requested review of this revision. REVISION SUMMARY Otherwise some action, especially when there is only one action, it will be

D28859: Detect QQC2 version at build time with actual detection.

This revision was automatically updated to reflect the committed changes. Closed by commit R858:aa57b34f75f0: Detect QQC2 version at build time with actual detection. (authored by xuetianweng). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.k

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. In D28859#652379 , @davidedmundson wrote: > So the problem we're solving is that we want to go > > Qt5.12 - QQC2.5 > Qt5.13 - QQC2.6 > Qt5.14 - QQC2.7 > Qt5.15 - QQC2.15 > > correct? > > We now kn

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng updated this revision to Diff 80646. xuetianweng added a comment. Just fix the version by if-else check. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80227&id=80646 BRANCH master REVISION DETAIL https:

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. ping? :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28859 To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fb

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. In D28859#649191 , @davidedmundson wrote: > I don't understand. > > We're still running this at compile time, so what's the practical difference? The old implement hard-codes it to (minor_version - 7), wh

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng updated this revision to Diff 80227. xuetianweng added a comment. fix header REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80226&id=80227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28859

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng created this revision. xuetianweng added reviewers: Plasma, rizzitello, davidedmundson, apol, mart. xuetianweng added a project: Plasma. Herald added a subscriber: plasma-devel. xuetianweng requested review of this revision. REVISION SUMMARY Whenever qqc release a new version the ver

D22535: Make kimpanel a system tray applet

xuetianweng requested changes to this revision. xuetianweng added a comment. This change doesn't serve any real functionality of kimpanel. It doesn't show the current input method in tray, doesn't hide or show up. And kimpanel usually consist multiple icons. While it's doubt whether we need t

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. Not so sure why phabricator didn't set you as the commit author... sorry about that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: davidedmundson, plasma-devel, ZrenBot, lesliez

D11061: Migration request from IBusConfig to GSettings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e2a29f8ea072: Migration request from IBusConfig to GSettings (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11061?vs=28920&id=2896

D11061: Migration request from IBusConfig to GSettings

xuetianweng added inline comments. INLINE COMMENTS > panel.cpp:922 > +impanel_update_engines(impanel, var_engines); > +if (var_engines) > +g_variant_unref(var_engines); https://community.kde.org/Policies/Kdelibs_Coding_Style#Braces Always use braces > panel.cpp:933 > +impan

D11061: Migration request from IBusConfig to GSettings

xuetianweng requested changes to this revision. xuetianweng added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > panel.cpp:1049 > +g_signal_handlers_disconnect_by_func (impanel->settings_hotkey, > (gpointer)impanel_settings_changed_callback, impanel); > +

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. In D11061#219841 , @davidedmundson wrote: > FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem imho, this is pretty irrelevant here.. gsettings is not directly gconf and gconf itself is deprecated

D11061: Migration request from IBusConfig to GSettings

xuetianweng added inline comments. INLINE COMMENTS > panel.cpp:1031 > impanel->xkbLayoutManager = new XkbLayoutManager; > +impanel->settings_general = g_settings_new (IBUS_SCHEMA_GENERAL); > +impanel->settings_hotkey = g_settings_new (IBUS_SCHEMA_HOTKEY); IMHO you need to g_object_u

D11061: Migration request from IBusConfig to GSettings

xuetianweng requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11061 To: fujiwara, #plasma, hein, xuetianweng Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

D11061: Migration request from IBusConfig to GSettings

xuetianweng added a comment. May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work? If so I'd like to see a version check on ibus at compile time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabr

D10498: Workaround the touchpad toggle button not working

xuetianweng accepted this revision. xuetianweng added a comment. I sent the comment before you corrected the diff branch. LGTM. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: plasma-de

D10498: Workaround the touchpad toggle button not working

xuetianweng accepted this revision. xuetianweng added a comment. This revision is now accepted and ready to land. Oh, ok.. now the diff looks normal. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xue

D10498: Workaround the touchpad toggle button not working

xuetianweng added a comment. Emm, mind to get rid of the .desktop part for this review? Also I think you need to give some explanation about why this works. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: p

D8529: Plasma change icons should exit after its work finished.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8529?vs=2145

D8529: Plasma change icons should exit after its work finished.

xuetianweng added a comment. In https://phabricator.kde.org/D8529#186000, @broulik wrote: > Good to go, no? I have no problem with that. Any one have extra comment? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart,

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#175698, @subdiff wrote: > Sorry for the long delay on a review. > > Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is availab

D8798: Add xf86-input-libinput support for X11 mouse backend.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec352304d357: Add xf86-input-libinput support for X11 mouse backend. (authored by xuetianweng). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8798?vs=22774&id=23472#toc REPOSITORY R119 Plas

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#175698, @subdiff wrote: > Sorry for the long delay on a review. > > Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is availab

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. @jriddell ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma, jriddell Cc: jriddell, apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mar

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#170892, @jriddell wrote: > This disables the input kcm if libinput x11 plugin is not found. I expect this is fine, it is for ubuntu distros at least, but it might be worth asking distros if it causes them a problem.

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng updated this revision to Diff 22774. xuetianweng added a comment. revert the accidentally changed currentIndex in ui file when save in designer. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8798?vs=22543&id=22774 BRANCH mouse REVISI

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. Whether it shows up reallys depends on your system. Especially when there's multiple mouse driver available and you may using evdev. For example, here's one output on my system, when you see something like this, you'll know it's using libinput's xf86 driver.

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. @apol got a chance to test it? REPOSITORY R119 Plasma Desktop BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: apol, rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a comment. In https://phabricator.kde.org/D8798#169156, @apol wrote: > In https://phabricator.kde.org/D8798#169155, @ngraham wrote: > > > $ kcmshell5 touchpad > > kcm_touchpad: Using X11 backend > > > > > > The file on disk is at `/usr/lib/x86_64-linux-gn

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng updated this revision to Diff 22543. xuetianweng added a comment. Fix based on comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8798?vs=22284&id=22543 BRANCH mouse REVISION DETAIL https://phabricator.kde.org/D8798 AFFECTED FI

D8770: Resolve the input method issue by always force focus in search field.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:44d8a7500e36: Resolve the input method issue by always force focus in search field. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D8771: Use heuristic weighted length algorithm to calculate the query term length.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:55a8d72e9786: Use heuristic weighted length algorithm to calculate the query term length. (authored by xuetianweng). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng updated this revision to Diff 22289. xuetianweng marked an inline comment as done. xuetianweng added a comment. Use the new kcoreaddons function to cal the length. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8771?vs=22234&id=22289 B

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8798 To: xuetianweng, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8798: Add xf86-input-libinput support for X11 mouse backend.

xuetianweng created this revision. xuetianweng added a reviewer: ngraham. Restricted Application added a project: Plasma. REVISION SUMMARY Added libinput support to X11 backend. It also adds an new option to backend which is only available to libinput device currently. TEST PLAN Manually te

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng marked an inline comment as done. xuetianweng added inline comments. INLINE COMMENTS > cfeck wrote in servicerunner.cpp:52 > Since there is no 'else', the length is increased by 3 for Han characters. Is > this intended? Yeah you're right.. I intended to use else here. REPOSITORY

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng updated this revision to Diff 22234. xuetianweng added a comment. forget to use else.. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8771?vs=22214&id=22234 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8771 AFFECTED

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng updated this revision to Diff 22214. xuetianweng added a comment. Revert the accident checking length change. Also make weightedLength linkage local. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8771?vs=22213&id=22214 BRANCH maste

D8771: Use heuristic weighted length algorithm to calculate the query term length.

xuetianweng created this revision. xuetianweng added reviewers: hein, broulik. Restricted Application added a project: Plasma. REVISION SUMMARY Composing CJK character requires a lot more key comparing to latin characters. The raw length check does not make much sense for query string in CJK

D8770: Resolve the input method issue by always force focus in search field.

xuetianweng updated this revision to Diff 22212. xuetianweng added a comment. revert the reordering of code in unrelated part REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8770?vs=22211&id=22212 BRANCH master REVISION DETAIL https://phabricato

D8770: Resolve the input method issue by always force focus in search field.

xuetianweng created this revision. xuetianweng added reviewers: hein, mart. Restricted Application added a project: Plasma. REVISION SUMMARY ActivityManager.qml doesn't have input method issue because the initial focus is inside the text field. So here we try to apply the same logic. Always

D8585: Preserve the order in dbus menu when doing action reusing.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:46aaa0e76c7b: Preserve the order in dbus menu when doing action reusing. (authored by xuetianweng). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8585?vs=

D8585: Preserve the order in dbus menu when doing action reusing.

xuetianweng added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D8585 To: xuetianweng, #plasma, davidedmundson, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:40f8edd70f4a: Refactor kcm_input to enable having multiple backends. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8460?vs=21675&

D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng abandoned this revision. xuetianweng added a comment. Being split into small patches REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: subdiff, ngraham, plasma-devel, leezu, ZrenBot, alexeymin, progwolff

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng reclaimed this revision. xuetianweng added a comment. .. Sorry click on the wrong one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8460 To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng abandoned this revision. xuetianweng added a comment. To be split into small patches. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8460 To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D8529: Plasma change icons should exit after its work finished.

xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8460 To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng added a comment. In https://phabricator.kde.org/D8460#161613, @subdiff wrote: > In https://phabricator.kde.org/D8460#160642, @xuetianweng wrote: > > > Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only > > get a virtual cursor. Thus I just move

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng updated this revision to Diff 21675. xuetianweng marked 8 inline comments as done. xuetianweng added a comment. Remove backend check so xwayland settings may be changed. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8460?vs=21674&id=2167

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng added inline comments. INLINE COMMENTS > subdiff wrote in mousebackend.h:26 > Put this enum class in a separate file, such that you don't have to include > the full mousebackend.h in other header files like mouse.h I guess I can put it in mousesettings.h .. > subdiff wrote in mouse

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng updated this revision to Diff 21674. xuetianweng marked 11 inline comments as done. xuetianweng added a comment. update based on comments. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8460?vs=21404&id=21674 BRANCH master REVISION DE

D8585: Preserve the order in dbus menu when doing action reusing.

xuetianweng created this revision. xuetianweng added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY Right now, new Action always appends to the list, but application may want to add new action in the middle of the menu. This breaks such ap

D8529: Plasma change icons should exit after its work finished.

xuetianweng added a comment. @mart I understand what you want to say, but for this specific case: https://lxr.kde.org/source/frameworks/kio/src/widgets/kbuildsycocaprogressdialog.cpp#0037 rebuildKSycoca invokes dialog.exec() so it returns after the rebuild is done. And thus ther

D8529: Plasma change icons should exit after its work finished.

xuetianweng created this revision. xuetianweng added reviewers: apol, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Right now plasma-iconchanges may remains on the system after change the icon theme. TEST PLAN

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng updated this revision to Diff 21404. xuetianweng added a comment. Update accroding to subdiff's comment. Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only get a virtual cursor. Thus I just move the condition to check the name of qpa platform for no

D8460: Refactor kcm_input to enable having multiple backends.

xuetianweng created this revision. xuetianweng added reviewers: subdiff, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Split patch for https://phabricator.kde.org/D8168. This change only refactor

D8456: Port kcm input to UI File.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:987b4dec9264: Port kcm input to UI File. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8456?vs=21268&id=21269 REVISION DETAIL

D8456: Port kcm input to UI File.

xuetianweng updated this revision to Diff 21268. xuetianweng added a comment. Merge kmousedlg.ui into kcmmouse.ui. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8456?vs=21262&id=21268 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D8456: Port kcm input to UI File.

xuetianweng created this revision. xuetianweng added reviewers: subdiff, davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY A split version of https://phabricator.kde.org/D8168. This only refactors th

D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng added a comment. ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng retitled this revision from "kcm_input: Refactor the code to enable support of multiple backends." to "kcm_input: Refactor the code and add support for libinput under X11". xuetianweng edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://ph

D8168: kcm_input: Refactor the code and add support for libinput under X11

xuetianweng edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D8168 To: xuetianweng, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8168: kcm_input: Refactor the code to enable support of multiple backends.

xuetianweng updated this revision to Diff 20440. xuetianweng added a comment. using a UI file and add libinput support. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8168?vs=20421&id=20440 BRANCH master REVISION DETAIL https://phabricator.kde.

D8168: kcm_input: Refactor the code to enable support of multiple backends.

xuetianweng created this revision. xuetianweng added reviewers: davidedmundson, mart. Restricted Application added a project: Plasma. REVISION SUMMARY Refactor the code like kcm_touchpad to enable support for different backend. Right now we only have X11. TEST PLAN Manually tested on weston

D8149: Add support for gtk3 theme variant feature.

This revision was automatically updated to reflect the committed changes. Closed by commit R98:59c62319781b: Add support for gtk3 theme variant feature. (authored by xuetianweng). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8149?vs=20363&id=20371 REV

D8149: Add support for gtk3 theme variant feature.

xuetianweng created this revision. xuetianweng added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. REVISION SUMMARY Gtk3 supports theme variant feature, which allows application to specify a variant theme to use. TEST PLAN Test with gtk3-demo -> Applicat

D1075: Display mouse image in mouse kcm properly on highdpi screen

xuetianweng abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1075 To: xuetianweng, apol, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7436: kimpanel: change highlight color

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5377b6b03b8d: kimpanel: change highlight color (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18624&id=18628 REVISION DET

D7436: kimpanel: change highlight color

xuetianweng added a comment. That's a bug in breeze. Should be fixed with https://phabricator.kde.org/D7491 REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D7436 REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot,

D7436: kimpanel: change highlight color

xuetianweng edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7436: kimpanel: change highlight color

xuetianweng updated this revision to Diff 18624. xuetianweng added a comment. Use plasma svg as highlight REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7436?vs=18451&id=18624 BRANCH arcpatch-D7436 REVISION DETAIL https://phabricator.kde.org/D7

D7436: kimpanel: change highlight color

xuetianweng commandeered this revision. xuetianweng added a reviewer: guoyunhe. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: xuetianweng, #plasma, guoyunhe Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D7436: kimpanel: change highlight color

xuetianweng added a comment. Can you try to make use of PlasmaComponents.Highlight instead of custom highlight like this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7436 To: guoyunhe, #plasma Cc: xuetianweng, plasma-devel, ZrenBot, progwolff, lesliezhai

D4879: notifications: Correctly display the file in jobs

This revision was automatically updated to reflect the committed changes. Closed by commit R120:403b7348e168: notifications: Correctly display the file in jobs (authored by xuetianweng). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4879?vs=18412&id=

D4879: notifications: Correctly display the file in jobs

xuetianweng updated this revision to Diff 18412. xuetianweng added a comment. update based on david's comments. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4879?vs=12041&id=18412 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

xuetianweng accepted this revision. xuetianweng added a comment. Yeah, killing input method is not a great idea, not to mention ibus is not the only one messing with keyboard layout. If people really want to know what's messing around I'd rather check the input method's dbus name and throw a

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0dee59dcf28: Implement the new panel icon size ceiling also for Input Method Panel. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

xuetianweng updated this revision to Diff 14812. xuetianweng added a comment. inPanel is not used. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5962?vs=14811&id=14812 BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5962 AFFEC

D5962: Implement the new panel icon size ceiling also for Input Method Panel.

xuetianweng created this revision. xuetianweng added a project: Plasma. REVISION SUMMARY It was done for various other applets but not this. BUG:378443 REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.10 REVISION DETAIL https://phabricator.kde.org/D5962 AFFECTED FILES applets/kimp

D5054: Make sure clock in lock screen is displayed within screen

xuetianweng abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5054 To: xuetianweng, #plasma, graesslin Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4996: Fix invalid reference of toolTipArea.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2f5dbfbc1560: Fix invalid reference of toolTipArea. (authored by xuetianweng). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4996?vs=12347&id=12492 REVISIO

D4996: Fix invalid reference of toolTipArea.

xuetianweng added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4996 To: xuetianweng, hein, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5054: Make sure clock in lock screen is displayed within screen

xuetianweng created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY On certian screen setup, e.g. 2560x1440 with scale factor 2, the clock text will be displayed outside the screen. This change make the clock align with the top of the screen instead of use mar

D4996: Fix invalid reference of toolTipArea.

xuetianweng updated this revision to Diff 12347. xuetianweng added a comment. fix may be applied to 5.9 branch REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4996?vs=12346&id=12347 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D

D4996: Fix invalid reference of toolTipArea.

xuetianweng created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY When activateTask is called from root Item, it will fail to resolve the reference of toolTipArea. This change make toolTipArea a property of Task and make activateTask() access it via this pro

D4879: notifications: Correctly display the file in jobs

xuetianweng added a comment. View Revision In D4879#91745, @mart wrote: In D4879#91664, @xuetianweng wrote: (If not, ship this. it seems fine) Label0 is also used elsewhere. We could add another value to engine though, not sure if worth it. it's used in the job delegate and as an error message

[Differential] [Commented On] D4879: notifications: Correctly display the file in jobs

xuetianweng added a comment. In https://phabricator.kde.org/D4879#91642, @davidedmundson wrote: > Label0 comes from the dataengine > We have some nice C++ methods to get a filename from a URL, can we do it there? > > (If not, ship this. it seems fine) Label0 is also used el

[Differential] [Request, 5 lines] D4879: notifications: Correctly display the file in jobs

xuetianweng created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY For url with parameter like audiocd:/1.wav?device=/dev/sr0, the filename displayed in notifications applet is not correct ("sr0") instead of 1.wav. This commit try to remove the query string b

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#72924, @graesslin wrote: > I would say the overall problem is that this here still uses an XLib event queue. But Qt uses an xcb connection. I would say this needs a porting away from the XLib code and use Qt's XCB connecti

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71988, @graesslin wrote: > In https://phabricator.kde.org/D3829#71877, @xuetianweng wrote: > > > In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > > > > > Could you explain the relationship to global sh

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71724, @knambiar wrote: > Might this change fix this issue? https://bugs.kde.org/show_bug.cgi?id=370588 Yeah, I suspect so. I already put it in CCBUG, but I'd prefer reporter to confirm it. REPOSITORY R119 Plasm

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng added a comment. In https://phabricator.kde.org/D3829#71714, @graesslin wrote: > Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel I don't really sure about this. So basically XlibNotifications

[Differential] [Request, 31 lines] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng created this revision. xuetianweng added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason, the XI event is not received if the change is from global shortcut. This m

[Differential] [Closed] D3372: Remove Webkit usage in potd data engine.

xuetianweng closed this revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3372 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: xuetianweng, mart, hein, broulik Cc: #plasma, plasma-devel, lesliezhai, ali-moha

  1   2   3   4   >