D11746: Assign notification area category

wsdfhjxc added a comment. All of them seem to be accepted, but I can't land anything by myself. Feel free to do it on your own. REPOSITORY R116 Plasma Network Management Applet BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11746 To: wsdfhjxc, #plasma, broulik Cc: Pitel,

D11750: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11749: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11748: Assign notification area category

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352

D11746: Assign notification area category

wsdfhjxc created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY This is a supplement for D11352 . REPOSITORY R116 Plasma Ne

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. Unfortunately, comparing by `item.text` with a non-US language enabled makes the result worse than on previous screenshot (especially the order of items within the `Hardware` group is very odd). To get it consistent regardless of system's language setting it might b

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. They are `org.kde.plasma.keyboardindicator` and `org.kde.discovernotifier`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel Cc: wsdfhjxc, mart, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. Thanks for a fix. I've changed the category order to - `UnknownCategory` - `ApplicationStatus` - `Communications` - `SystemServices` - `Hardware` and updated `metadata.desktop` for some Plasma components - Networks -> `Hardware`

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. In D11352#227154 , @mart wrote: > yes, categories of those items need to be fixed, this was kinda forgotten as in plasma5 unfortunately the systray wasn't really using them It would be great if that happened. The

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. > That seems like you are getting some javascript error in `updateItemVisibility`. Can look at what plasma shell is reporting (or paste it here)? There are no other errors except of `ConfigEntries.qml:228:34: Unable to assign [undefined] to QKeySequence` spam w

D11352: [RFC] Auto ordered systray

wsdfhjxc added a comment. Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state doesn't make any difference and the items are neither in panel nor in hidden panel, th

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. Currently dragging active items into the trash bin and saving changes results in setting auto visibility and displaying them at the end of both the system tray and configuration list, so it's not really deleting them from user's point of view. I was wondering, shoul

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I can no longer reproduce the issue with incorrect visibility state in checkboxes. It seems to be working correctly after last patch. Also, I've added some minor styling suggestions, so it looks a little bit more polished in my opinion. INLINE COMMENTS > Confi

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. I think it would be better to place new items on the left side of the system tray, as this is closer to default behavior. Also, sometimes the visibility state is updated incorrectly after moving items back and forth (showing hidden state for visible items). Other th

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. In D11292#224949 , @Pitel wrote: > I am aware of `getFixedItemId`, only forgot to mention it in summary. Right now it is not included mostly because it is another hack (but fixing stupid behavior of someone else so unav

D11292: [RFC] Ordered system tray v2

wsdfhjxc added a comment. As for the getFixedItemId function (which was connected to an id trimming method in my example), it was because of Dropbox client's StatusNotifier item having some random number suffix. Without this, at every boot it was duplicated in the new config list-type proper

D11233: Ordered system tray

wsdfhjxc updated this revision to Diff 29307. wsdfhjxc added a comment. - Wait for the item id before inserting it into tray - Sort the tray items by categories and ids REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11233?vs=29275&id=29307 BRANC

D11233: Ordered system tray

wsdfhjxc updated this revision to Diff 29275. wsdfhjxc added a comment. - Squashed commit of the following: - Use theme based icons instead of char glyph labels for buttons - Use QRegularExpression instead of QRegExp REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://p

D11240: Introduce a new config entry for auto and shown item ordered list

wsdfhjxc abandoned this revision. wsdfhjxc added a comment. Sorry, I've messed something while playing with Arcanist. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11240 To: wsdfhjxc Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D11240: Introduce a new config entry for auto and shown item ordered list

wsdfhjxc created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this revision. REVISION SUMMARY Introduce a new abstract item ordered list position property Provide a method for registering

D11233: Ordered system tray

wsdfhjxc created this revision. wsdfhjxc added a reviewer: Plasma: Workspaces. wsdfhjxc added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. wsdfhjxc requested review of this