D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added inline comments. INLINE COMMENTS > broulik wrote in ksystemactivitydialog.cpp:79 > Is it intentional you removed the `KeepAbove`? Yes, per my interpretation of the comment that application shouldn't force it's window properties like that because it interferes with WM settings

D12837: Split replaceAccount from addAccountToCache

This revision was automatically updated to reflect the committed changes. Closed by commit R128:ff88e24e4380: Split replaceAccount from addAccountToCache (authored by valeriymalov). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12837?vs=34027&id=34304 R

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. I meant it more in terms of "not landing it right before next stable release" :v But if it's okay to land now I can land it right now REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D12837 To: valeriymalov, #plasma,

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. In D12837#262817 , @ngraham wrote: > Any chance we could land this on the stable branch? Well, it does apply cleanly to Plasma/5.12 branch and it still works, but I don't really know if there's a special proc

D12837: Split replaceAccount from addAccountToCache

valeriymalov added inline comments. INLINE COMMENTS > davidedmundson wrote in accountmodel.cpp:361 > On second look, I might have misunderstood. > > This isn't a replace, it's just making sure the current user is at the top? Yes. Replace code was added to `addAccountToCache` at some point becau

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. > We have addAccountToCache which has an argument pos, which determines if we're adding or replacing. I've actually removed this bit, addAccountToCache now only adds accounts (either inserts at pos or appends) Though I agree that current code is probabl

D12837: Split replaceAccount from addAccountToCache

valeriymalov created this revision. valeriymalov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. valeriymalov requested review of this revision. REVISION SUMMARY We were accidentally overwriting first account in t

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. I've tried to restore old behavior, so: - If I run KWindowConfig::restoreWindowSize from dialog's constructor, it doesn't work on multi-monitor setup very well. windowHandle()→screen() seems to be set to leftmost screen (which isn't even primary in my case;

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. In D3484#239893 , @cfeck wrote: > It is the application that sets the window size. Since the initial size is likely wrong, applications usually remember sizes of windows and important dialogs. If the applicat

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. In D3484#238571 , @cfeck wrote: > But it does no longer remember window size now (and for whatever reason, I cannot get the kwin rules to force an initial window size to work). I thought the consensus was that

D3484: Center systemmonitor window properly on multi-screen setup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:ad5b9e98b1f2: Center systemmonitor window properly on multi-screen setup (authored by valeriymalov). REPOSITORY R120

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov updated this revision to Diff 29239. valeriymalov added a comment. another rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3484?vs=28410&id=29239 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3484 AFFECTED FIL

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov updated this revision to Diff 28410. valeriymalov edited the summary of this revision. valeriymalov added a comment. Rebased from master & fed through arcanist Any objections if I'll just land it soon? REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://ph

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

valeriymalov abandoned this revision. valeriymalov added a comment. kcm_input seems to be getting proper refactor in https://phabricator.kde.org/D8168 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7558 To: valeriymalov, #plasma, #vdg Cc: graesslin, mart, pl

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov updated this revision to Diff 21043. valeriymalov edited the summary of this revision. valeriymalov added a comment. I've just realized that config save/load that I've deleted is pretty important since it also configures the KSysGuardProcessList widget (including update interval

D7890: add size hint to KScreen KCM

valeriymalov added a comment. Not really REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D7890 To: valeriymalov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7890: add size hint to KScreen KCM

valeriymalov created this revision. valeriymalov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This should help kcmshell opening this kcm at a reasonable size without forcing it REPOSITORY

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

valeriymalov added a comment. It does work with both evdev-controlled pointers, libinput-controlled pointers and even on Wayland. As far as I understand, it just controls how Qt apps react to single "full" scroll event. It's doesn't affect system scroll speed, although takes it in account.

D7558: kcms/input: Allow WheelScrollLines = 0; some code cleanup

valeriymalov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This should allow user to disable scrollwheel in KDE/Qt apps This does not seem to affect non-Qt apps, e.g. Google Chrome, but they ig

D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov updated this revision to Diff 15251. valeriymalov added a comment. So I've decided to revisit this and ended up deleting most of the code, dunno if I went overboard here. Replaced resize and setGeometry calls with sizeHint() for the window. I've also removed call to minimumS

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. I'm not familiar with KDE, but it seems that's how krunner manages it's position too (method View::positionOnScreen in krunner/view.cpp), except that it doesn't use windowHandle() and derives current screen from cursor position, and takes struts in account

[Differential] [Request, 2 lines] D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov created this revision. valeriymalov added a reviewer: Plasma: Workspaces. valeriymalov set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. valeriymalov added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Wo