D20086: Fix window height of Screen Locking KCM

tigrang added a comment. @ngraham Sorry for the late response. > Let's land this now and then you can try the other approach in another patch (if you want to). Sounds good. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20086 To: tigrang, davidedmun

D20086: Fix window height of Screen Locking KCM

tigrang added a comment. @filipf Here's a diff with units.gridUnit https://phabricator.kde.org/differential/diff/54998/ which doesn't quite work out to 2 rows for every scaling factor but is a bit better than hard-coded pixel size. I'm not sure how to do doubling the height of one grid item.

D20086: Fix window height of Screen Locking KCM

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY An implicitHeight must be set on QML components to prevent window size being too small. BUG: 400355 TEST PLAN 1. Open Scree

D20072: Fix Default Applications KCM window size

tigrang updated this revision to Diff 54963. tigrang added a comment. Removed foreach and fixed coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20072?vs=54898&id=54963 REVISION DETAIL https://phabricator.kde.org/D20072 AFFECTED FILES

D20072: Fix Default Applications KCM window size

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY Config widgets were loading in when a service item was clicked. This change loads all config widgets at the start so the window ca

D20055: Fixed initial size and content width of Activity Settings KCM

tigrang added a comment. Before: https://i.imgur.com/KEHZK7S.png After with only minSize set: https://i.imgur.com/XJ63Hzn.png After with minSize + col span change: https://i.imgur.com/1EYeUOx.png The alignment of the last screenshot may not be desirable so please check that. REPOSITO

D20055: Fixed initial size and content width of Activity Settings KCM

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY Tab contents are added when KActivities::Consumer::serviceStatusChanged signal is fired which happens after the layout is set. This

D20027: Fix initial width/height in KCMs that use qml

tigrang added a comment. Note: There are modules in other packages that still need to be fixed for bug 398820 like Workspace settings in plasma-desktop. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20027 To: tigrang Cc: plasma-devel, jraleigh, GB_2, ragreen,

D20027: Fix initial width/height in KCMs that use qml

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY This change fixes width/height for File Index Manager and Energy Information modules. BUG: 398820 REPOSITORY R102 KInfoCent

D19959: Fixed issue causing changed signal to be called with false argument

tigrang added a comment. I do not have commit access. Can you commit for me, please? Full Name: Tigran Gabrielyan Email: tigran...@gmail.com REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19959 To: tigrang, mlaurent Cc: mlaurent

D19959: Fixed issue causing changed signal to be called with false argument

tigrang created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tigrang requested review of this revision. REVISION SUMMARY AdvanceConfig::changed signal is called with changed=false arguement when QGroupBox::clicked is called with checked=false causing t