D23799: Get rid of khtml usage (kill classic mode)

2019-09-10 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R124:03892b3b0dc7: Get rid of khtml usage (kill classic mode) (authored by svuorela). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23799?vs=65675&id=65737 REV

D23799: Get rid of khtml usage (kill classic mode)

2019-09-09 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: vkrause, plasma-devel. Herald added a project: Plasma. svuorela requested review of this revision. REVISION SUMMARY khtml is going away, so remove the classic mode that relies on it TEST PLAN It's optional, so it can go without much be

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a subscriber: mlaurent. svuorela added a comment. Let's try poke @mlaurent and see if he has any comments. I still think it is mostly a visualization issue. the mail client just tells what it knows. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366536 , @ngraham wrote: > What I'm saying is that I think it makes more sense to communicate your preferred email workflow to KMail rather then to Plasma. I'm open to being convinced out of this point of view

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366525 , @ngraham wrote: > > I feel like this patch trying to work around a problem in either your workflow Is plasma seriously going to try to dictate my email workflow? > Maybe 1000 wo

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. In D17152#366495 , @anthonyfieroni wrote: > So i like second one, it can still be fixed to 10K+ because it does not matter above. I'm still unsure what I as a user should use the number for ? It is not like I'm

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. F6442734: image.png is just with a + F6442738: image.png is around current code F6442740: image.png is this proposal I'll try with + for a cou

D17152: Hide the badge if number too big

2018-11-26 Thread Sune Vuorela
svuorela added a comment. @ngraham I use kmail ... but I have hundreds of thousands unread emails without counting my spam folders. (commit lists, bug lists, ...) @anthonyfieroni I think that doesn't convey any actual information. "You have a lot of unread emails and doesn't use the coun

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela added a comment. @ngraham It might be that many notifications != no notifications in some cases, but at least in the case of emails, with many unread emails basically doesn't make a difference. I have a coulpe of hundred thousand unread emails + the emails in my spamfolder whic

D17152: Hide the badge if number too big

2018-11-25 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: Plasma, hein, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. svuorela requested review of this revision. REVISION SUMMARY A + badge on the email conveys no actual information that the user isn't al

D10628: Optional barcodes in libprison

2018-02-24 Thread Sune Vuorela
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c6e678a274b6: Adapt to further nullpointers from prison (authored by svuorela). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10628?vs=27455&id=27910 REV

D10628: Optional barcodes in libprison

2018-02-18 Thread Sune Vuorela
svuorela edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10628 To: svuorela, graesslin, vkrause Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10628: Optional barcodes in libprison

2018-02-18 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: graesslin, vkrause. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. svuorela requested review of this revision. REVISION SUMMARY createBarcode can sometimes return nullpointers. In

Re: Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-13 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128904/#review99158 --- Ship it! Ship It! - Sune Vuorela On Sept. 14, 2016, 1

Re: Review Request 128633: Wether nor not install the private header?

2016-08-08 Thread Sune Vuorela
rs if a specific feature is not compiled in. At runtime. So things can be enabled/disabled as needed without requiring changes in other parts of the code. It is a very deliberate action to not install the headers any more. - Sune Vuorela On Aug. 9, 2016, 6:03 a.m., Leslie Zhai

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Su

Re: [kde-packager] Re: [kde-packager] Plasma 5 RC

2014-07-04 Thread Sune Vuorela
On Friday 04 July 2014 11:13:19 Vishesh Handa wrote: > I would really like the tarballs to have the same name. Also, baloo4 and 5 > are not really co-installable. They both ship executables with the same > name. Are you saying that one can't use a kdepim with baloo support in a plasma workspace w

Re: Notifications-future, a recap

2012-09-20 Thread Sune Vuorela
On 2012-09-17, Dario Freddi wrote: > It really depends on what you want to achieve. If your goal is just > cleaning up the API and implementing the existing standard it might > work out, but for sure it won't just cut it for what I proposed, where Why won't the existing (as in the fdo/galago spec

Re: [4.7 Beta1 blocker] plasma depending on kdelibs/experimental

2011-05-21 Thread Sune Vuorela
On 2011-05-21, Dirk Mueller wrote: > Is the previous rule no longer valid? otherwise, how to deal with this > situation? Move plasma to experimental? remove the dependency again? That rule is still valid. And. how is one supposed to be building kdelibs if it requires kdelibs-experimental which