D25428: Improved support for desktop "Folder View"

steffenh added a comment. New version of the patch is here: https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/170 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: st

D25428: Improved support for desktop "Folder View"

steffenh added a comment. I'm working on another version of this patch at the moment. The new version doesn't need a MouseArea in the FolderItemDelegate. If the new patch is ready, I will make a merge request on GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricato

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 71583. steffenh added a comment. remove debug messages REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=71052&id=71583 BRANCH arcpatch-D25428 REVISION DETAIL https://phabricator.kde.org/D25428 AFFE

D25428: Improved support for desktop "Folder View"

steffenh added a comment. I was trying to use the TapHandler, but I came across a problem with DragAndDrop that I need help with. If I try a DragAndDrop with touch the following happens: - I get a drag cursor, but i get no drag icon - if I release the touch the drag don`t end, I ne

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Ok a quick look at TapHandler, first I am missing a positionChanged signal in the TapHandler and second we need to change QtQuick from 2.8 to 2.12. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ng

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Hi @ngraham, That's a good news. I will make a new patch in the next days, without the debug messages. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfe

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 71052. steffenh added a comment. get ride of all simulated mouse clicks change behavior for touch (similar to touch in kickoff): - access to the context menu after tapandhold and release touch - drag and drop after tabandhold and moving don't

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Hi @ngraham, thanks for testing, OK, I will rewrite this and see if I can get rid of all the simulated mouse clicks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham, nicolasf

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70597. steffenh added a comment. don't use simulated double mouse click to open/launch an item. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70247&id=70597 BRANCH arcpatch-D25428 REVISION DETAIL

D25428: Improved support for desktop "Folder View"

steffenh added a comment. @ngraham thanks again for testing, Ok, so it's just the double click simulation was is not working 100% on your laptop, I think I can work with it. On the other hand, if I am lucky I can borrow a HPSpectre x360 in the next days, too test this directly. RE

D25428: Improved support for desktop "Folder View"

steffenh added a comment. First, thank for testing @nicolasfella and @ngraham Ok, now I am clueless. @ngraham maybe you can tell me, witch tablet and software version you used? If you have time, perhaps you can make a test without my patch. Move the cursor with the mouse over

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70247. steffenh added a comment. simulate left mouse click, if touchtap ended REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70078&id=70247 BRANCH folderview REVISION DETAIL https://phabricator.kd

D25428: Improved support for desktop "Folder View"

steffenh updated this revision to Diff 70078. steffenh added a comment. oops was wrong diff, now is it the correct version REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25428?vs=70066&id=70078 BRANCH touchFolderView REVISION DETAIL https://pha

D25428: Improved support for desktop "Folder View"

steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY moving icon's on the desktop around with touch open/launch icons with tap (only singe tap, re

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 69785. steffenh edited the summary of this revision. steffenh added a comment. rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60216&id=69785 BRANCH D21829 REVISION DETAIL https://phabricato

D21829: Improved Touch support for Kickoff

steffenh added a comment. Hi @hein. > Before we discuss alternatives: Are you willing to have me try and teach you? I'm actually going to be very busy with a move in the next few weeks, so this could end up taking quite significant time between the two of us, but if you have the time an

D21829: Improved Touch support for Kickoff

steffenh added a comment. Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry. I have the last days looking at plasma-frameworks, but my knowledge of the working of plasm

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60216. steffenh added a comment. change variable name from tapandhold to tapAndHold REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21829?vs=60018&id=60216 BRANCH kickoff REVISION DETAIL https://phabricator

D21829: Improved Touch support for Kickoff

steffenh added inline comments. INLINE COMMENTS > ngraham wrote in KickoffListView.qml:142 > Probably so click-and-hold doesn't trigger these behaviors when not using a > touchscreen. This is the Fix for Bug: 406361 In the appView the listView.currentItem will get open, but listView.currentItem

D21829: Improved Touch support for Kickoff

steffenh updated this revision to Diff 60018. steffenh added a comment. - Drag icon now follows the touch point - to make the drag icon better visible, set the drag icon size for touch drag from medium to huge and move the drag icon a bit to the top and left REPOSITORY R119 Plasma Desktop

D21829: Improved Touch support for Kickoff

steffenh created this revision. steffenh added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. steffenh requested review of this revision. REVISION SUMMARY - enabled touch scrolling in Kickoff - open the correct category in the application tab - o