D17784: Don't ignore default virtual devices

2019-01-23 Thread Stefanos Harhalakis
sharhalakis added a comment. Stefanos Harhalakis REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: filipf, ngraham, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17784: Don't ignore default virtual devices

2019-01-19 Thread Stefanos Harhalakis
sharhalakis added a comment. Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity. REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: filipf, ngraham, cfeck, plasma-devel, jraleig

D17784: Don't ignore default virtual devices

2019-01-17 Thread Stefanos Harhalakis
sharhalakis added a comment. Fixed. I'm not sure if I need to press a button or something to request another review though. REVISION DETAIL https://phabricator.kde.org/D17784 To: sharhalakis, broulik, drosca Cc: cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali

D17784: Don't ignore default virtual devices

2019-01-17 Thread Stefanos Harhalakis
sharhalakis updated this revision to Diff 49776. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17784?vs=48152&id=49776 REVISION DETAIL https://phabricator.kde.org/D17784 AFFECTED FILES src/pulseaudio.cpp To: sharhalakis, broulik, drosca Cc: cfeck, plasma-devel, jraleigh, GB_2, ra

D17784: Don't ignore default virtual devices

2018-12-24 Thread Stefanos Harhalakis
sharhalakis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sharhalakis requested review of this revision. REVISION SUMMARY Ignoring virtual PA devices for volume control results in ignoring the "Simultaneous output" devices. This makes it imposs

Review Request: Change behavior of "Windows can cover" panel option

2009-04-16 Thread Stefanos Harhalakis
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/598/ --- Review request for Plasma. Summary --- Make "Windows can cover" option an au

Re: Review Request: Change behavior of "windows can cover" option

2009-04-16 Thread Stefanos Harhalakis
> > the && should be on the line above (just how we roll :) OK. done. - Stefanos --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/597/#review939 --- On 2009-04-16 11:23:19, Ste

Review Request: Change behavior of "windows can cover" option

2009-04-16 Thread Stefanos Harhalakis
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/597/ --- Review request for Plasma. Summary --- Make "windows can cover" option to lo

Re: Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-08 Thread Stefanos Harhalakis
tion? I only see 4 (including "windows should cover"). - Stefanos --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/537/#review867 -

Review Request: Add a "Windows should cover" option to plasma panels.

2009-04-07 Thread Stefanos Harhalakis
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/537/ --- Review request for Plasma. Summary --- Add a "Windows should cover" option t