D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. I took another look. As I already mentioned, there seems to be a difference between how `onLoginFailed` signals work in both. In the lock screen: - the `onLoginFailed`

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Friendly ping! Since the behaviour is already different, can we merge this one and work on the SDDM part in a later PR? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: davi

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Hi David! Hmm, it seems the behavior is already different. I don't use sddm, but I tried it just now and found that the input field is already *not* disabled, plus, the notification that the login failed comes after the timeout. Looking at the qml code, t

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. This one was easy enough. I definitely liked the fact that I could edit the qml files directly and test it live without going through a compilation step. I especially enjoyed it after I managed to crash the lock screen with a typo but was able to fix the stuck

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Cool! Thank you for the pointers to the correct place. It was much easier than I thought once I looked at the code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: plasma-d

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. That's correct. 2 points however: - I think the detection of a wrong password is very fast and at least on my system I immediately get the highlighted focus. When you say muted, is it slow to do this for you? - We probably can't do the immediate focus be

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu updated this revision to Diff 58025. siddharthasahu added a comment. Update diff to master. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21192?vs=58019&id=58025 REVISION DETAIL https://phabricator.kde.org/D21192 AFFECTED FILES

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. siddharthasahu requested review of this revision. REVISION SUMMARY This is a patch to fix: https://bugs.kde.org/show_bug.cgi?id=407473 TEST PLAN I applied the diff on my system by di

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

/apps/", which is a root protected directory. This means unpriviledged kdesrc-builds to a separate CMAKE_PREFIX_PATH is now failing, because it does not have permission to write to /usr/share/apps/kconf_update/disable_kmix.upd Ideas on making this work without needing sudo priviledges? -

Re: Review Request 125323: Continue even if script returns errors

work, but the sourced variabled are then discarded. It should be `test -r "$file" && . "$file" || true` (lets use `true` instead of `:` for better clarity?) - Siddhartha Sahu On Sept. 20, 2015, 9:2