D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. I took another look. As I already mentioned, there seems to be a difference between how `onLoginFailed` signals work in both. In the lock screen: - the `onLoginFailed`

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Friendly ping! Since the behaviour is already different, can we merge this one and work on the SDDM part in a later PR? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: davi

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Hi David! Hmm, it seems the behavior is already different. I don't use sddm, but I tried it just now and found that the input field is already *not* disabled, plus, the notification that the login failed comes after the timeout. Looking at the qml code, t

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. This one was easy enough. I definitely liked the fact that I could edit the qml files directly and test it live without going through a compilation step. I especially enjoyed it after I managed to crash the lock screen with a typo but was able to fix the stuck

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. Cool! Thank you for the pointers to the correct place. It was much easier than I thought once I looked at the code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21192 To: siddharthasahu, ngraham, #plasma, #vdg Cc: plasma-d

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu added a comment. That's correct. 2 points however: - I think the detection of a wrong password is very fast and at least on my system I immediately get the highlighted focus. When you say muted, is it slow to do this for you? - We probably can't do the immediate focus be

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu updated this revision to Diff 58025. siddharthasahu added a comment. Update diff to master. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21192?vs=58019&id=58025 REVISION DETAIL https://phabricator.kde.org/D21192 AFFECTED FILES

D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end

siddharthasahu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. siddharthasahu requested review of this revision. REVISION SUMMARY This is a patch to fix: https://bugs.kde.org/show_bug.cgi?id=407473 TEST PLAN I applied the diff on my system by di

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

/apps/", which is a root protected directory. This means unpriviledged kdesrc-builds to a separate CMAKE_PREFIX_PATH is now failing, because it does not have permission to write to /usr/share/apps/kconf_update/disable_kmix.upd Ideas on making this work without needing sudo priviledges? -

Re: Review Request 125323: Continue even if script returns errors

work, but the sourced variabled are then discarded. It should be `test -r "$file" && . "$file" || true` (lets use `true` instead of `:` for better clarity?) - Siddhartha Sahu On Sept. 20, 2015, 9:2

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

On 8 July 2015 at 23:37, Aleix Pol wrote: > I cannot reproduce this, can you tell me what warning you get? > Is it when configuring polkit-kde-agent-1? It happens for all modules which generate a .policy file https://bugs.kde.org/show_bug.cgi?id=350034 Plasma session hanging due to polkit-kde-au

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

les were failing with error "could not find .policy file. Will file a bug with details sometime later :P Regards, Siddhartha ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma 5 is awesome...and some help required with build instructions

On 19 May 2015 at 16:00, David Edmundson wrote: > Yes, it's only a problem on Kubuntu. > > It's also solvable by compiling Qt, but I don't really want to have to force > new devs to do that unless I have to. We should talk to the Kubuntu devs to see why its hardcoded that way, and ask them to re

Re: Plasma 5 is awesome...and some help required with build instructions

On 18 May 2015 at 22:58, David Edmundson wrote: > Just setting up on a new machine and thought I'd try following these > instructions exactly, the way a new developer would. > > I got stuck on something I don't know how to solve. > > Under Kubuntu because Qt is compiled with a hardcoded plugindir

Re: Plasma 5 is awesome...and some help required with build instructions

On 1 April 2015 at 00:58, Bernhard Friedreich wrote: > I finally found the problem - the instructions on the wiki were updated > since my setup and I was lacking some lib64 directories in the runPlasma5.sh > script.. Ah yes, sorry about that. I have some additional config which installs all libra

Re: Plasma 5 is awesome...and some help required with build instructions

Hey Martin, Thanks for all the comments :) On 30 March 2015 at 16:11, Martin Klapetek wrote: >> sudo chown -R user:group /opt/kde > > I think this should either use $USER or `whoami` rather than "user" ? Hmm good point. Also I learned that leaving the group empty after a colon automatically set

Re: Plasma 5 is awesome...and some help required with build instructions

Hi David, Thanks a lot for your comments! On 28 March 2015 at 20:23, David Edmundson wrote: > I don't think we should tell people to download's David Faure's > kdesrc-buildrc file. It has "/d" hardcoded a lot. > > If we make our own we don't need people to change it and can have the same > dire

Plasma 5 is awesome...and some help required with build instructions

something not set in my environment correctly. Cheers, Siddhartha ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel