D28686: [Battery Monitor] Choose better wording

shubham abandoned this revision. shubham added a comment. Pushed here 38ebcf09b1631175d5a1b4d857622c5313146a60 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Ping?? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Friendly ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35e18420a76a: [kcm_nightcolor] Set 2 decimal places precision for coordinates (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28958?vs

D28958: [kcm_nightcolor] Set 2 decimal places precision for coordinates

shubham created this revision. shubham added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH coor REVISION DETAIL https://phabricator.kde.org/D28958 AFFECTED

D28686: [Battery Monitor] Choose better wording

shubham added a comment. @broulik Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham

D28686: [Battery Monitor] Choose better wording

shubham updated this revision to Diff 79686. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28686?vs=79662&id=79686 REVISION DETAIL https://phabricator.kde.org/D28686 AFFECTED FILES applets/batterymonitor/package/contents/ui/logic.js

D28686: [Battery Monitor] Choose better wording

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH fix-wording REVISION DETAIL https://phabricator.kde.org/D28686 AFFECTED FILES applets

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

shubham added a comment. +1 Personally I had faced this issue when I had bought a new monitor and tried to listen to music through its speakers. I couldn't figure out how to switch play back devices for couple of days or so. REPOSITORY R115 Plasma Audio Volume Applet REVISION D

D23044: [Notifications] Swing the bell when there is a new notification

shubham added a comment. Personally I do not like info button to be swung like a bell, however VDG are the right people to decide this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23044 To: broulik, #plasma, #vdg Cc: shubham, plasma-devel, LeGast00n

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a79ff3db16f: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22619?vs=62213

D22588: [Pager] Don't link kdelibs4support

shubham added a comment. I have put up a patch to remove duplicate occurrence of DBus here. https://phabricator.kde.org/D22619 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma, hein, davidedmundson Cc: pino, shubham, plasma-devel

D22619: Remove duplicate occurence of Qt5::DBus in CMakeLists.txt

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22619 AFFECTED FILES applets/pager/CMakeLists.txt

D22588: [Pager] Don't link kdelibs4support

shubham added inline comments. INLINE COMMENTS > CMakeLists.txt:18 >Qt5::Core >Qt5::DBus >Qt5::Qml Could you please remove this or the occurrence below at line 21? REPOSITORY R119 Plasma Desktop REVISION DE

D22481: Do not show play/pause button when no media is playing

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22481 AFFECTED FILES lookandfeel/contents

D20804: RFC: Try getting the X keyboard grab multiple times

shubham added inline comments. INLINE COMMENTS > interface.h:116 > > +void AboutToLock(); > + Shouldn't this and the above function name start with small letter? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To: davidedmundson,

D18766: Don't show tooltip when search field has text

This revision was automatically updated to reflect the committed changes. Closed by commit R134:c62901d8aed6: Don't show tooltip when search field has text and set a timeout period (authored by shubham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D18766: Don't show tooltip when search field has text

shubham added a comment. In D18766#409139 <https://phabricator.kde.org/D18766#409139>, @ngraham wrote: > Yes, let's land it. Please land it on the 5.15 branch and then merge to master. If you don't know how to do that, I can help you. Help will be welcome.

D18766: Don't show tooltip when search field has text

shubham added a comment. @ngraham Is it now behaving as it should? REPOSITORY R134 Discover Software Store BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. In D18766#408901 <https://phabricator.kde.org/D18766#408901>, @ngraham wrote: > Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source witho

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. It compiles but I could not test this. When I run the plasma-discover segmentation fault prevails. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh

D18766: Don't show tooltip when search field has text and set a timeout period

shubham updated this revision to Diff 51272. shubham added a comment. Remove timeout period REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18766?vs=50977&id=51272 BRANCH search REVISION DETAIL https://phabricator.kde.org/D1

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. @apol about the timeout? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. >> I'm not sure you even need to add the `timeout: ` line at all. A tooltip with a negative timeout does not hide automatically. The default value is -1. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. When user is typing text, the tooltip continuosly shown above distracts and looks ugly REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel

D18766: Don't show tooltip when search field has text and set a timeout period

shubham marked an inline comment as done. shubham added a comment. @apol I have noticed that the tooltip is seen even when there is text present, also the duration for which it appears is very long REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org

D18766: Don't show tooltip when search field has text and set a timeout period

shubham updated this revision to Diff 50977. shubham added a comment. Use length REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18766?vs=50975&id=50977 BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 AFFECTED F

D18766: Don't show tooltip when search field has text and set a timeout period

shubham created this revision. shubham added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Earlier, the tooltip was continuosly shown even though it was observed when search field was empty

D17751: Add shadow to Hour's hand

This revision was automatically updated to reflect the committed changes. Closed by commit R120:975df8f8930c: Add shadow to Hour's hand (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17751?vs=49728&id=49796 REVISI

D17751: Add shadow to Hour's hand

shubham updated this revision to Diff 49728. shubham added a comment. Updating D17751 <https://phabricator.kde.org/D17751>: Add shadow to Hour's hand Use harcoded pixel values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17751?

D17751: Add shadow to Hour's hand

shubham updated this revision to Diff 49656. shubham added a comment. 1. Set the hour hand shadow's topMargin to -6px and second hand shadow's topMargin to 2px 2. Use units.smallSpacing instead of hardcoding the values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDA

D17751: Add shadow to Hour's hand

shubham added a comment. ngraham I will put those changes in effect REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17751 To: shubham, mart, hein, #vdg, ngraham Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel

D17752: Remove full representation of analog clock

shubham abandoned this revision. shubham added a comment. Abandon in favor of above discussion. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17752 To: shubham, hein, mart, #vdg Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen

D17598: Improve "No internet connection!" error message

shubham added a comment. @rooty yeah, it depends on the available space. The main motive should be full up the empty space. @ngraham Is there any possible representation where we can just eliminate or use up that empty space. REPOSITORY R134 Discover Software Store BRANCH better-no

D17598: Improve "No internet connection!" error message

shubham added a comment. In D17598#384293 <https://phabricator.kde.org/D17598#384293>, @ngraham wrote: > In D17598#384289 <https://phabricator.kde.org/D17598#384289>, @shubham wrote: > > > Looking nice. Not being nitpicky, what's the default behaviour,

D17598: Improve "No internet connection!" error message

shubham added a comment. Looking nice. Not being nitpicky, what's the default behaviour, the icon should be on top or to the free space on the left? REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL

D17598: Improve "No internet connection!" error message

shubham accepted this revision. shubham added a comment. This revision is now accepted and ready to land. Looks good this way round. +1 REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL https

D17598: Improve "No internet connection!" error message

shubham added a comment. It will look much better. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D17598: Improve "No internet connection!" error message

shubham added a comment. Shouldn't the second part of the sentence be in its own line? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17598 To: ngraham, #discover_software_store, #vdg, apol Cc: shubham, pino, plasma-devel, GB_2, ragreen,

D17751: Add shadow to Hour's hand

shubham added a comment. In D17751#381435 <https://phabricator.kde.org/D17751#381435>, @ndavis wrote: > In D17751#381431 <https://phabricator.kde.org/D17751#381431>, @shubham wrote: > > > How could the shadow appearance be fixed? In breeze icons? >

D6056: [Run Command] Auto-close on focus loss only if query field is empty

shubham added a comment. Year and half old patch, lucky it got noticed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel

D17751: Add shadow to Hour's hand

shubham added a comment. How could the shadow appearance be fixed? In breeze icons? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17751 To: shubham, mart, hein, #vdg, ngraham Cc: abetts, ngraham, davidedmundson, plasma-devel, GB_2, ragreen, Pitel

D17752: Remove full representation of analog clock

shubham created this revision. shubham added reviewers: hein, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Full representation of analog clock showed a calendar, which does not makes sense for two

D17751: Add shadow to Hour's hand

shubham created this revision. shubham added reviewers: mart, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. TEST PLAN Add new analog clock widget from "Add widget" on right click context m REPOSITORY R

D17556: Make Status and Notification popup consistent with others.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:743e5583ced0: Make Status and Notification popup consistent with others. (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17556?vs

D17574: Remove period ( . ) character from the end

This revision was automatically updated to reflect the committed changes. Closed by commit R120:998d1a02c670: Remove period ( . ) character from the end (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17574?vs=47551&id=4

D17556: Make Status and Notification popup consistent with others.

shubham added a comment. could I go ahead pushing it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma, mart Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D17556: Make Status and Notification popup consistent with others.

shubham updated this revision to Diff 47562. shubham added a comment. Use units.smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17556?vs=47552&id=47562 REVISION DETAIL https://phabricator.kde.org/D17556 AFFECTED FILES app

D17574: Remove period ( . ) character from the end

shubham added a comment. my battery drained in "After" image even though it was charging : ) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: GB_2, plasma-devel, squeakypancakes, alexde, Ioha

D17556: Make Status and Notification popup consistent with others.

shubham updated this revision to Diff 47552. shubham edited the summary of this revision. shubham removed a reviewer: hein. shubham added a comment. use 5px margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17556?vs=47497&id=47552 REVI

D17574: Remove period ( . ) character from the end

shubham created this revision. shubham added reviewers: Plasma, VDG. shubham added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Before: F6476200: 1.png <https://phabricator.kde.org/F6476200> After: F6

D17556: Make Status and Notification popup consistent with others.

shubham added a comment. @broulik In all others, if you notice it is 0 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D17556: Make Status and Notification popup consistent with others.

shubham created this revision. shubham added a project: Plasma. Herald edited subscribers, added: plasma-devel; removed: Plasma. shubham requested review of this revision. REVISION SUMMARY 1. Remove the left margin. 2. Change '&' to "and". Before:

D17532: Show tooltip for pinning system tray and calendar

This revision was automatically updated to reflect the committed changes. Closed by commit R120:977d2aadd522: Show tooltip for pinning system tray and calendar (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17532?vs=47433&am

D17532: Show tooltip for pinning system tray and calendar

shubham updated this revision to Diff 47433. shubham edited the summary of this revision. shubham added a comment. "Keep Open" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17532?vs=47432&id=47433 REVISION DETAIL https://phabr

D17532: Show tooltip for pinning system tray and calendar

shubham created this revision. shubham added reviewers: mart, Plasma. shubham added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY F6472870: 1.png <https://phabricator.kde.org/F6472870> REPOSITORY R120 Plasma Wor

D17360: Added "Transparent with light text" theme for Desktop Notes

shubham added a comment. Congrats on your first patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D17360 To: IamMaxim, #plasma, davidedmundson Cc: shubham, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D16257: Use correct wording, since it is an action word(not a noun)

shubham created this revision. shubham added a reviewer: Plasma. shubham added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16257 AFFECTED FILES applets

D14652: Port to KRun::runApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e0d50ff1d88d: Port to KRun::runApplication (authored by shubham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14652?vs=39199&id=39206 REVISION DE

D14652: Port to KRun::runApplication

shubham created this revision. shubham added reviewers: jgrulich, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https

Project: Better touch screen support in the Plasma workspace

Hello, I came across the Touch screen support Idea for KDEsoc and I am interested in contributing for the same. How should I go about for the same. I have basic knowledge of Qt and experienced in C++. Moreover I have been using plasma,KDE for quite some time now. Thanks.