D9506: milti-screen sleep fix

2018-01-10 Thread Sergey Turchin
zerg added a comment. According debug info "if (info.isNull())" may be always false and "case true:" never break. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwol

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-14 Thread Sergey
https://bugs.kde.org/show_bug.cgi?id=376344 Sergey changed: What|Removed |Added CC||rion...@gmail.com --- Comment #22 from Sergey

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Sergey Popov
/ Testing --- Tests passed Thanks, Sergey Popov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
/kplugins/plugintest.h a99701a tests/kplugins/plugintest.cpp 3d98dec tests/testengine/testengine.cpp 76947c3 Diff: https://git.reviewboard.kde.org/r/126672/diff/ Testing --- Tests passed Thanks, Sergey Popov ___ Plasma-devel mailing list

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
t; > What's the rationale for this change? Clazy warned "-Wclazy-non-pod-global-static" on it before my change. - Sergey --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-07 Thread Sergey Popov
/plugintest.cpp 3d98dec tests/testengine/testengine.cpp 76947c3 Diff: https://git.reviewboard.kde.org/r/126672/diff/ Testing --- Tests passed Thanks, Sergey Popov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-07 Thread Sergey Popov
/ Testing (updated) --- Tests passed Thanks, Sergey Popov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125567: Use the original path if QStandardPaths::locate fails

2015-10-09 Thread Sergey Kalinichev
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 03aba97a6f32aa405032369d93e0fb2d0c968f91 by Sergey Kalinichev to branch master. Repository: kde-cli-tools Description --- This fixes assert in KPropertiesDialog::KPropertiesDialog for me Diffs

Review Request 125567: Use the original path if QStandardPaths::locate fails

2015-10-09 Thread Sergey Kalinichev
--- This fixes assert in KPropertiesDialog::KPropertiesDialog for me Diffs - keditfiletype/kservicelistwidget.cpp 62d5b78 Diff: https://git.reviewboard.kde.org/r/125567/diff/ Testing --- Thanks, Sergey Kalinichev ___ Plasma-devel

Re: Review Request 121350: 5 Krazy2 issues fix for plasma-mediacenter

2014-12-04 Thread Popov Sergey
, Popov Sergey ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121350: 5 Krazy2 issues fix for plasma-mediacenter

2014-12-04 Thread Popov Sergey
/next/contents/applet/DefaultCompactRepresentation.qml 3b49cdf CMakeLists.txt d670466 libs/mediacenter/album.cpp 3893f17 Diff: https://git.reviewboard.kde.org/r/121350/diff/ Testing --- Thanks, Popov Sergey ___ Plasma-devel mailing list

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
On May 18, 2010, Petri Damstén wrote: > It was stacked before but there were complains that it's hard to > read what is the value of the top graph, so it was changed to be not > stacked. But it's currently stacked without a patch, isn&

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
etPlotCount(int, const QList &). Ok. New patch attached. -- Sergey diff -ur system-monitor/net.cpp system-monitor-new2/net.cpp --- system-monitor/net.cpp 2010-05-17 07:15:02.0 +0300 +++ system-monitor-new2/net.cpp 2010-05-19 03:49:13.0 +0300 @@ -93,7 +93,8 @@ SM::Plotter

Re: [patch] Fix network monitor colors and stacking

2010-05-18 Thread Sergey
Also in case of network load red and green colors are widely spread and different color may confuse people. At least it confuses me. :) > I'm sorry if I have hijacked this thread. As for me any suggestions are welcome. -- Sergey ___ Plas

[patch] Fix network monitor colors and stacking

2010-05-17 Thread Sergey
As suggested in http://bugs.kde.org/show_bug.cgi?id=237922 I'm sending a patch here as well. Problem: It's very hard to understand on the network monitor plasmoid which line is download and which is upload speed. They also stack and this is not really usual for this kind of graphs. Solut