D28281: Add options for OSD feedback

sgoth added a comment. I see. Then i'll let $things happen. Thanks! REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack Cc: The-Feren-OS-Dev,

D28281: Add options for OSD feedback

sgoth added a comment. Cool thanks! As this is my first contribution via phabricator, can you give me a short advice on how to proceed? Do i "arc land" it myself? To master? REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISION DETAIL ht

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78498. sgoth added a comment. Refactor show functions to be members of VolumeOsd REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78495&id=78498 BRANCH volumeosdcfg (branched from master) REV

D28281: Add options for OSD feedback

sgoth marked an inline comment as done. sgoth added a comment. Ah, that seems a lot better yes, thanks. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik, ngraham, drosca, cblack Cc: cblack, drosca, ngraham, pl

D28281: Add options for OSD feedback

sgoth added a comment. Yeah, was unsure too if it's a good idea but now with your sanitized wording i'd prefer it that way :) But if i should go for a single OSD on/off i wouldn't mind either. REPOSITORY R115 Plasma Audio Volume Applet BRANCH volumeosdcfg (branched from master) REVISI

D28281: Add options for OSD feedback

sgoth added a comment. now with spacing F8198928: image.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-O

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78495. sgoth added a comment. Add spacing REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78494&id=78495 BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78494. sgoth added a comment. Change wording REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78483&id=78494 BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.k

D28281: Add options for OSD feedback

sgoth added a comment. "default output" "Default output" "Default output device" ? looks like this then: F8198919: image.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg

D28281: Add options for OSD feedback

sgoth marked an inline comment as done. sgoth added a comment. Oh.. good catch thanks :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To: sgoth, #vdg, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28281: Add options for OSD feedback

sgoth updated this revision to Diff 78483. sgoth added a comment. Fix typo REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28281?vs=78456&id=78483 BRANCH volumeosdcfg (branched from master) REVISION DETAIL https://phabricator.kde.org

D28281: Add options for OSD feedback

sgoth added a comment. F8198388: image.png Not sure about the actual wording and whether we would want all 3 of them. Probably would use "input volume", "output volume" but i tried to match the existing "aural feedback" string. Also i actually

D28281: Add options for OSD feedback

sgoth created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sgoth requested review of this revision. REVISION SUMMARY Extend configuration knobs for visual feedback by adding separate ones for output volume, input volume and mute state. BUG: 36398