D24720: [applets/systemtray] Rewrite popups with layouts

safaalfulaij added a comment. Hi :) Please tag me in case you need any RTL help. Yes, headers are aligned based on direction before, which was bad. It's almost better to align them to the other side even if they're not translated. You never know. And good that you spotted the issue with

D10083: [Look and Feel] Reverse the button order

safaalfulaij abandoned this revision. safaalfulaij added a comment. Thanks for making stuff consistent! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: ngraham, abetts, davidedmundson, plasma-devel, GB_2,

D15683: Add lock icon to desktop context menu

safaalfulaij added a comment. Why not also add icons to other items instead of other X number of commits coming later by Y number of people? Yes, some don't have “group” icon (like sort, where only ascending and descending are available), but I don't see a problem if we used any “child” one

D15011: [Kickoff] Make the search field always look like a search field

safaalfulaij added a comment. In D15011#314738 , @filipf wrote: > Exactly! In your second proposal I don't think the serachbox sticks out, even as it is. At least to me it looks fine. At the same time it is drawing back, albeit not totally, to o

D15011: [Kickoff] Make the search field always look like a search field

safaalfulaij added a comment. Why don't we have a simple search icon that indicates that one can search in the kickoff, and once you click on it you get switched to the search layout, where you'll find a note saying you can also search by direct typing, and a “Got it” as many websites does?

D15011: [Kickoff] Make the search field always look like a search field

safaalfulaij added a comment. The original issue (in Neon/Kubuntu task, not sure) was that Kickoff is not clear if one can search or not, because of text changing. Why not just keeping the current “Type to search” label as is, and move the user@host text up as in the patch? Also please

D14869: [RFC] Increase default font sizes by 1 pt

safaalfulaij added a comment. I use an old laptop with 1280×800 display (not like you should really count for it, this is old). Noto Sans 10, good readable (but ugly for Arabic): F6198491: Screenshot_٢٠١٨٠٨١٦_١٠٤٨٣٢.png Noto Sans 11, huge (and u

D13372: Mouse KCM Redesign Using Kirigami

safaalfulaij added a comment. Small question, why we're not using QQC2-based controls? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13372 To: furkantokac, ngraham, romangg, mart Cc: safaalfulaij, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali

D12102: Port Language KCM to Qt Quick

safaalfulaij added inline comments. INLINE COMMENTS > translationsmodel.cpp:124 > + > +QString TranslationsModel::languageCodeToName(const QString& languageCode) > const > +{ About this and the fact the Qt doesn't still have an API for returning the language according to the current locale, ma

D10592: fix RTL appearance for ComboBox

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Now since I'm a reviewer, sure :) REPOSITORY R242 Plasma Framework (Library) BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart,

D10592: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D10592#209670 , @mvourlakos wrote: > @safaalfulaij is there a green light for this? Sure. Go ahead and commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D

D10592: fix RTL appearance for ComboBox

safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > -LayoutMirroring.enabled: true > +// HACK: When the ComboBox is not inside the base Item, it does > not inherit > +// the LayoutMirroring options.

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. Reported: https://bugreports.qt.io/browse/QTBUG-66446 Although this is really unlikly to happen, a widget having a combobox, but this is the case of Latte where the whole config overlay is just a `MouseArea`. REPOSITORY R242 Plasma Framework (Library) REVISI

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207623 , @mvourlakos wrote: > Can you build Latte from master version? All comboboxes in its settings window are PlasmaComponents3 :) Ok, I can assume that Latte doens't have a `Window`/`Application

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. I've done some more testing and read some Qt docs. `Popup` item get reparented to the window once displayed, so LayoutMirroring is applied to it only at that point (applying it to the contentItem). So my comments above about `Popup` not inheerting `Item` are wr

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207435 , @mvourlakos wrote: > > Would you please add a HACK so that we know when to remove this? > > You mean as a comment ? Yes, preferably with the Qt bug number and some explanation. REPOSITORY

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207260 , @mvourlakos wrote: > @mart I fixed this issue by changing these lines to: > > 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > 114Layo

D10111: [Klipper] Force plain text on the edit dialog

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:bac2ae0cd272: [Klipper] Force plain text on the edit dialog (authored by safaalfulaij). REPOSITORY R120 Plasma Works

D10111: [Klipper] Force plain text on the edit dialog

safaalfulaij updated this revision to Diff 25978. safaalfulaij added a comment. setAcceptRichText REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10111?vs=25973&id=25978 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10111 AFFECTE

D10111: [Klipper] Force plain text on the edit dialog

safaalfulaij added a comment. This is how it looks currently: F5675251: Screenshot_٢٠١٨٠١٢٦_٠٧٤٨٢٣.png With the patch we'll get `Test` instead in the textedit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1

D10111: [Klipper] Force plain text on the edit dialog

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25924. safaalfulaij added a comment. Align the warning text to the right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25902&id=25924 BRANCH master REVISION DETAIL https://phabricator.kde.org

D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Yes I do. But shall we ask VDG or not? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohame

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25902. safaalfulaij added a comment. Leftover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25901&id=25902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 AFFECTED FILES k

D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Look and feel: F5673030: Screenshot_٢٠١٨٠١٢٤_٢١٠٧٠٢.png Other KCMs: F5673029: Screenshot_٢٠١٨٠١٢٤_٢١٠٧١٠.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D10083: [Look and Feel] Reverse the button order

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY The look and feel KCM is using a different button o

D9786: [Kickoff] Fix RTL issues

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b127e545b552: [Kickoff] Fix RTL issues (authored by safaalfulaij). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25384&id=25386 REVISION DETAIL h

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25384. safaalfulaij added a comment. - 0 instead of undefined - change statments order REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25138&id=25384 BRANCH master REVISION DETAIL https://phab

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190606, @mvourlakos wrote: > To test it in Latte I added in the head of /shell/package/contents/configuration/AppearanceConfig.qml > > import org.kde.plasma.components 3.0 as PlasmaComponents3 > > > and I set u

D9275: fix RTL appearance for ComboBox

safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > +LayoutMirroring.enabled: true > +LayoutMirroring.childrenInherit: true So it is true even for LTR locales? REPOSITORY R242 Plasma Framework (Library) REVI

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190569, @mvourlakos wrote: > with your example me I cant reproduce it either... > I can only reproduce it with Latte Settings window, all other components are aligned correctly except the PlasmaComponent3.Combobox list

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190497, @mvourlakos wrote: > how did you test it? > > I tried in an qml app (Latte dock) by passing the parameter "--reverse"... > If your system is already using in RTL language, have you tried with --reverse?

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In https://phabricator.kde.org/D9275#190464, @mvourlakos wrote: > In https://phabricator.kde.org/D9275#190441, @safaalfulaij wrote: > > > Can you please explain why these are needed? I tested plasmacomponents3 and the c

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. Can you please explain why these are needed? I tested plasmacomponents3 and the combobox was working correctly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos,

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25138. safaalfulaij added a comment. - Align header labels to left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25137&id=25138 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25137. safaalfulaij added a comment. - Just align it correctly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25073&id=25137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 AFF

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. In https://phabricator.kde.org/D9786#188720, @broulik wrote: > I see. > > How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of > > leftMargin: Math.max(0, width - contentWidth) > Well, that

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. I'll answer that here to put some visuals. This is before the patch, all fine, correct direction, but aligned to left: F5633510: step 1.png Here we mirror the graphics of the Flickable: F5633511: step 2.png

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. After applying: F5633478: kickoff_after.mp4 Sorry couldn't crop video REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma Cc: plasma-devel, ZrenBot, progw

D9786: [Kickoff] Fix RTL issues

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Fix 2 issues: - the breadcrumbs alignment -

D7715: [Plasma Components 3] Fix RTL in some widgets.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:940adc7e6e69: [Plasma Components 3] Fix RTL in some widgets. (authored by safaalfulaij). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7715?vs=1

D7715: [Plasma Components 3] Fix RTL in some widgets.

safaalfulaij added a comment. It seems that the `TabBar`'s problem is an upstream issue with `ListView` and highlighting animation. Will report about it soon. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7715 To: safaalfulaij

D7715: [Plasma Components 3] Fix RTL in some widgets.

safaalfulaij retitled this revision from "[WIP] Fix RTL in some plasmacomponents3 widgets." to "[Plasma Components 3] Fix RTL in some widgets.". REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7715 To: safaalfulaij, #plasma, #framewor

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij added inline comments. INLINE COMMENTS > broulik wrote in ProgressBar.qml:33 > That's pretty clever, actually, > > > A negative scale causes the item to be mirrored when rendered. > > However, not sure we can just blatantly mirror that graphic Actually, it’s used in default QQC2 s

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij added a comment. One widget I didn't know how to fix is the TabBar (The blue line that flows from left to right for the first item.) Other widgets are behaving the same as QQC2 ones, like BusyIndicator and Dial, so I didn't change them. Not sure if they should be flipped or not

D7715: [WIP] Fix RTL in some plasmacomponents3 widgets.

safaalfulaij created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some widgets are missed up in RTL mode, this should fix it. REPOSITORY R242 Plasma Framework (Library) BRANCH master REV

[Differential] [Updated] D2539: WIP: [Desktop Containment] Enable LayoutMirroring

safaalfulaij added a comment. > Analog clock still looks as in left-to-right (dunno how clocks in right-to-left languages look, though) xD Not for the clock :) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2539 EMAIL PREFERENCES https://pha