D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. Hey Jan, please make this commit on my behalf as I don't have commit access right now and I'm not planning to apply for it any time soon. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18689 To: rthomas, jgrulich, #

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51009. rthomas added a comment. I've also moved isConnectionTypeVirtual() in uiutils.cpp. Forgot to do that! REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=51006&id=51009 REVISION DETA

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 51006. rthomas added a comment. Moved isConnectionTypeVirtual() below isConnectionTypeSupported() REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50900&id=51006 REVISION DETAIL https:

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50900. rthomas added a comment. Shouldn't have removed the existing condition to check if the connection object is not valid. Added it back. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50899. rthomas added a comment. Hey Jan, I've made the changes you suggested. Let me know if anything needs to be fixed. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18689?vs=50771&id=50

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404502 , @jgrulich wrote: > This doesn't seem to be a correct fix. We should be using icon for whatever connection is primary, not only when primary connection is wifi / ethernet / modem / bluetooth. If you che

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. In D18689#404506 , @jgrulich wrote: > Correct fix would be to set icon for bridge connections in the last else branch at the end of setIcons() method, probably guarded with a condition whether the user has enabled virtua

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas updated this revision to Diff 50771. rthomas added a reviewer: Plasma. rthomas added a comment. Should have used '&&' in the if statement instead of '||'. We want to shift to the PrimaryConnection if the Device is not among Wifi, Ethernet, Modem and Bluetooth. Reason for choosing

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas created this revision. rthomas added a reviewer: jgrulich. rthomas added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. rthomas requested review of this revision. REVISION SUMMARY This bug has already been reported in bug 397352

D5870: Match subsequences in application runner

rthomas added a comment. @aacid : I have assigned the Plasma-Workspace repo to this revision. Please commit this patch on my behalf. I think I'll hold on for a while before applying for commit access. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5870 To

D5870: Match subsequences in application runner

rthomas set the repository for this revision to R120 Plasma Workspace. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma, davidedmundson Cc: aacid, davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D5870: Match subsequences in application runner

rthomas added a comment. No, I don't have commit access yet. Can I apply for a developer account now? I haven't done so until now. REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma, davidedmundson Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, le

D5870: Match subsequences in application runner

rthomas added a comment. Uh.. ping? REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5870: Match subsequences in application runner

rthomas marked 3 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D5870 To: rthomas, #plasma Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

D5870: Match subsequences in application runner

rthomas updated this revision to Diff 14603. rthomas added a comment. - Splitting the query using splitRef() instead of split() - Using QLatin1Char(' ') as the separator to split the query CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5870?vs=14559&id=14603 REVISION DETAIL http

D5870: Match subsequences in application runner

rthomas added inline comments. INLINE COMMENTS > apol wrote in servicerunner.cpp:101 > use a foreach I'm skipping the first string in strList because that string has already been accounted for relavace right before the call to increaseMatchRelavance. Relevance is incremented by 0.01 only based

D5870: Match subsequences in application runner

rthomas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Match applications in krunner using subsequences instead of substrings. This allows matching applications using parts of its name, instead of

D5770: Avoid showing wrong timezone suffix in krunner time

rthomas added a comment. I couldn't find a reasonable way to set the timezone from the returned country, so I think it's best to avoid it for now. I don't have commit access, David. This is the first time I'm working on the kdeplasma-addons repository. Please commit it on my behalf. REP

Re: Review Request 130006: Avoid showing wrong timezone suffix in krunner time

https://git.reviewboard.kde.org/media/uploaded/files/2017/03/11/b2109259-36a4-4b1a-aa73-750bead3569e__Screenshot_20170311_222355.png Thanks, Ronnie Thomas

D5770: Avoid showing wrong timezone suffix in krunner time

rthomas added reviewers: davidedmundson, broulik. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D5770 To: rthomas, davidedmundson, broulik Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5770: Avoid showing wrong timezone suffix in krunner time

rthomas created this revision. rthomas added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Krunner is suffixing the local timezone when asked for the time of other regions. QLocale doesn't provide a way to set the locale based only on the country

Review Request 130006: Avoid showing wrong timezone suffix in krunner time

-aa73-750bead3569e__Screenshot_20170311_222355.png Thanks, Ronnie Thomas