Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-05-23 Thread Ralf Jung
> On May 3, 2013, 8:52 p.m., Marco Martin wrote: > > any news on this? > > Martin, what do you think about it? Thomas fixed some existing issues which were uncovered by this patch, see https://bugs.kde.org/show_bug.cgi?id=179042#c71 . As far as I can tell, no other issues are known. - Ralf

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-04-10 Thread Ralf Jung
core kdelibs developer to have a look at this, so that this 4-year-old bug can finally be resolved? It'd be a shame if KDE 4.11 would ship without this patch. - Ralf Jung On March 23, 2013, 9:06 p.m., Thomas Lübking wrote: > >

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

2013-03-24 Thread Ralf Jung
the old and annoying issue of Plasma picking the wrong theme. - Ralf Jung On Jan. 9, 2013, 3 a.m., Thomas Lübking wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: kdev4 files in repositories

2013-03-13 Thread Ralf Jung
Hi, > Please delete them. done. Kind regards, Ralf ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: kdev4 files in repositories

2013-03-13 Thread Ralf Jung
Hi, >> kde-runtime/plasma/kpart/kpart.kdev4 70ca38b4 (Ryan James Rix 2010-09-04 23:23:35 + 1) [Project] 70ca38b4 (Ryan James Rix 2010-09-04 23:23:35 + 2) Manager=KDevCMakeManager 70ca38b4 (Ryan James Rix 2010-09-04 23:23:35 + 3) Name=kpart >> kdelibs/plasma/plasma.kdev4 89b71cd9 (Rob

kdev4 files in repositories

2013-03-12 Thread Ralf Jung
Hi, file cleaning up my ~/src, I stumbled upon two .kdev4 files which can be found in KDE git repositories (current master): kde-runtime/plasma/kpart/kpart.kdev4 kdelibs/plasma/plasma.kdev4 Were these committed on purpose? That seems quite unlikely to me, but nevertheless I don't want to j

Re: Review Request 109433: Zero size pager in default panel layout when in panel

2013-03-12 Thread Ralf Jung
Hi, thanks a lot, I can confirm it's working here :) (I did not test the update script though) Kind regards, Ralf On 12/03/13 11:29, Commit Hook wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revi

Re: The QML Pager plasmoid

2013-03-11 Thread Ralf Jung
Hi Plasma Developers, let me repeat what I already wrote in the bugreport [1]: I am kind of surprised that the pager was accepted as-is, but now there does not seem to be agreement any more on how it should behave. Clearly there was some intended behaviour when it got merged? Or nobody cared abou

Review Request: Revert "fix compilation with debian qjson"

2012-12-11 Thread Ralf Jung
, qjson is found and used. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix repositioning the toolbox when the widgets are locked

2012-09-22 Thread Ralf Jung
f you don't like temporarily changing the m_movable, I could also change the restore function to optionally ignore m_movable. - Ralf Jung On Sept. 16, 2012, 8:29 p.m., Ralf Jung wrote: > > --- > This is an automatically generat

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
t the graphical glitches after a resize are gone. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
ter a resize are gone. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
sma/desktop/shell/panelview.cpp 7713740 Diff: http://git.reviewboard.kde.org/r/106519/diff/ Testing --- Re-sized the screen a few times (using xrandr) to verify that the graphical glitches after a resize are gone. Thanks, Ralf Jung ___ Plasma-

Review Request: Fix panel redraw after screen resize

2012-09-21 Thread Ralf Jung
times (using xrandr) to verify that the graphical glitches after a resize are gone. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Ralf Jung
Hi, >> Ralf Jung wrote: Actually, the patch presented here does not break >> BC. This function I renamed is part of CalendarPrivate and >> therefore can not be used from the outside. The BC breakage would >> (possibly) be introduced by removing Calendar::resizeEvent

Re: Review Request: Make KDM compilation optional

2012-09-19 Thread Ralf Jung
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106444/#review18986 --- On Sept. 14, 2012, 10:26 a.m., Ralf Jung wrote: > > --

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-19 Thread Ralf Jung
ibly) be introduced by removing Calendar::resizeEvent, which is why I just stubbed it out to call the superclass function. - Ralf --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/1064

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Ralf Jung
- everything behaved as expected. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix repositioning the toolbox when the widgets are locked

2012-09-17 Thread Ralf Jung
addresses bug 302645. http://bugs.kde.org/show_bug.cgi?id=302645 Diffs - plasma/desktop/toolboxes/internaltoolbox.cpp 2c22b70 Diff: http://git.reviewboard.kde.org/r/106457/diff/ Testing --- The bug is not reproducible anymore. Thanks, Ralf Jung

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
e.org/show_bug.cgi?id=306762 Diffs (updated) - libs/plasmaclock/calendar.cpp 7ea70c2 Diff: http://git.reviewboard.kde.org/r/106441/diff/ Testing --- I verified that the bug is fixed - everything behaved as expected. Thanks, Ralf Jung ___ P

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
t; > Applying the config changing it to a different size is wrong in both cases. > > I'm not sure where the bug stems from, but this doesn't look like a good > > solution to me. > > > > Ralf Jung wrote: > Oops, I missed that handle as it only appears in the

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
Ralf --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review18976 ------- On Sept. 13, 2012, 9:27 p.m., Ralf Jung wrote: > > ---

Review Request: Make KDM compilation optional

2012-09-14 Thread Ralf Jung
default configuration and with BUILD_kdm=Off, verified that login worked and that the kcm is indeed gone. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix setting the size of the calendar of clocks

2012-09-13 Thread Ralf Jung
haved as expected. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Log whether libpam was found or not

2011-10-20 Thread Ralf Jung
x27;t know that macro_log_feature well) Diffs - ConfigureChecks.cmake b0d917e Diff: http://git.reviewboard.kde.org/r/102926/diff/diff Testing --- compile-tested Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-10-16 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102709/#review7382 --- Could somebody please have a look at this? - Ralf Jung On

Re: Review Request: XTest is an optional dependency, so skip a test that requires it if it is not found

2011-10-05 Thread Ralf Jung
kde.org/r/102771/#review7094 --- On Oct. 4, 2011, 6:52 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: Review Request: fix the problem that the text below the selected wallpaper is barely readable if the window is inactive

2011-10-05 Thread Ralf Jung
window is inactive or disabled. Diffs (updated) - plasma/generic/wallpapers/image/backgrounddelegate.cpp 8354d99 Diff: http://git.reviewboard.kde.org/r/102772/diff/diff Testing --- Compiled and checked whether the colours are fixed. Thanks, Ralf Jung

Review Request: fix the problem that the text below the selected wallpaper is barely readable if the window is inactive

2011-10-04 Thread Ralf Jung
/r/102772/diff/diff Testing --- Compiled and checked whether the colours are fixed. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: XTest is an optional dependency, so skip a test that requires it if it is not found

2011-10-04 Thread Ralf Jung
/diff/diff Testing --- kde-workspace compiles now. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-30 Thread Ralf Jung
n automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102713/#review6956 --- On Sept. 26, 2011, 8:01 p.m., Ralf Jung wrote: > > --- > This is an a

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-27 Thread Ralf Jung
ly, visit: http://git.reviewboard.kde.org/r/102713/#review6849 --- On Sept. 26, 2011, 8:01 p.m., Ralf Jung wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-26 Thread Ralf Jung
http://bugs.kde.org/show_bug.cgi?id=190081 Diffs (updated) - kmenuedit/basictab.cpp 4612c2a Diff: http://git.reviewboard.kde.org/r/102713/diff/diff Testing --- Compiled and logged in to see that the bug is actually fixed. Thanks, Ralf Jung __

Review Request: KMenuEdit: Fix disabling 'Only show in KDE'

2011-09-26 Thread Ralf Jung
mpiled and logged in to see that the bug is actually fixed. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Standard Actions KCM: Hide global column, and fix group name

2011-09-26 Thread Ralf Jung
Diff: http://git.reviewboard.kde.org/r/102709/diff/diff Testing --- Compile-tested, logged in and verified that the column indeed disappeared and the group name was fixed. Thanks, Ralf Jung ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma